Fixed typos in using l10n for localisation is typescript code and removed unused labels from bundles #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
naren2605
reviewed
Sep 29, 2024
naren2605
approved these changes
Sep 30, 2024
|
Can you please squash and push changes again? |
sid-srini
requested changes
Sep 30, 2024
There was a problem hiding this comment.
Thanks @shivam71 for writing the automated tests and finding these issues.
Can you please squash and push changes again?
I think due to one change on the same line in extension.ts across the 2 commits, the line is getting dropped altogether. Do squash and then re-verify if the usage of jdk.explorer.error_message.cannotDeleteNode is correct there.
Also, if possible, do include fixing the typo extenstion to extension in the various keys that use it. Thanks.
sid-srini
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After running automated tests for checking localisation found some typos and unused labels