Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge testing branch into main #283

Merged
merged 14 commits into from
Oct 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion build.xml
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@
patches/7654.diff
patches/7670.diff
patches/7699.diff
patches/7709.diff
patches/7722.diff
patches/7724.diff
patches/7733.diff
Expand Down Expand Up @@ -208,7 +209,7 @@
<copy file="vscode/package.json" todir="${build.dir}/bundles/package" />
<copy file="vscode/package-lock.json" todir="${build.dir}/bundles/package" />

<exec executable="mvn" failonerror="true" dir="${nb_all}/nbbuild/misc/prepare-bundles">
<exec executable="mvn${cmd.suffix}" failonerror="true" dir="${nb_all}/nbbuild/misc/prepare-bundles">
<arg value="package" />
<arg value="exec:java" />
<arg value="-Dexec.mainClass=org.netbeans.prepare.bundles.PrepareBundles" />
Expand Down
37 changes: 37 additions & 0 deletions patches/7709.diff
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
diff --git a/nbbuild/misc/prepare-bundles/src/main/java/org/netbeans/prepare/bundles/PrepareBundles.java b/nbbuild/misc/prepare-bundles/src/main/java/org/netbeans/prepare/bundles/PrepareBundles.java
index d24c6f5ec9..f2b040204e 100644
--- a/nbbuild/misc/prepare-bundles/src/main/java/org/netbeans/prepare/bundles/PrepareBundles.java
+++ b/nbbuild/misc/prepare-bundles/src/main/java/org/netbeans/prepare/bundles/PrepareBundles.java
@@ -58,7 +58,8 @@ public class PrepareBundles {
Pattern.compile("license", Pattern.CASE_INSENSITIVE),
Pattern.compile("LICENSE.txt", Pattern.CASE_INSENSITIVE),
Pattern.compile("LICENSE-MIT.txt", Pattern.CASE_INSENSITIVE),
- Pattern.compile("LICENSE.md", Pattern.CASE_INSENSITIVE)
+ Pattern.compile("LICENSE.md", Pattern.CASE_INSENSITIVE),
+ Pattern.compile("LICENSE.markdown", Pattern.CASE_INSENSITIVE)
);
private static final String nl = "\n";

@@ -69,7 +70,12 @@ public class PrepareBundles {

Path targetDir = Paths.get(args[0]);
Path packagesDir = targetDir.resolve("package");
- new ProcessBuilder("npm", "install").directory(packagesDir.toFile()).inheritIO().start().waitFor();
+ String os = System.getProperty("os.name").toLowerCase();
+ if (os.contains("windows")) {
+ new ProcessBuilder("npm.cmd", "install").directory(packagesDir.toFile()).inheritIO().start().waitFor();
+ } else{
+ new ProcessBuilder("npm", "install").directory(packagesDir.toFile()).inheritIO().start().waitFor();
+ }
Path bundlesDir = targetDir.resolve("bundles");
Files.createDirectories(bundlesDir);
try (DirectoryStream<Path> ds = Files.newDirectoryStream(bundlesDir)) {
@@ -107,6 +113,8 @@ public class PrepareBundles {
if ("@types".equals(module.getFileName().toString())) continue;
if ("@esbuild".equals(module.getFileName().toString())) continue;
if ("@microsoft".equals(module.getFileName().toString())) continue;
+ if ("eastasianwidth".equals(module.getFileName().toString())) continue;
+ if ("isarray".equals(module.getFileName().toString())) continue;
Path packageJson = module.resolve("package.json");
if (Files.isReadable(packageJson)) {
checkModule(module, sb, tokens2Projects, project2License, bundlesDir, targetDir, externalDir, binariesList);
Loading