added support for gradle 8.5 #108
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Achal Talati <[email protected]>
oracle-contributor-agreement
bot
added
the
OCA Verified
| + // Optimistic bias, if the GradleVersion is newer than the last NB | ||
| + // knows, we say it's compatible with any JDK | ||
| + return lastKnown.compareTo(version.getBaseVersion()) < 0 | ||
| + || jdkMajorVersion <= lastSupportedJava(); |
There was a problem hiding this comment.
can we make use of Gradle compatibility table given here https://docs.gradle.org/current/userguide/compatibility.html ?
There was a problem hiding this comment.
Yes maybe I don't know for sure, but currently it is manually handled in netbeans for every release. This patch is taken from apache/netbeans#6807
|
who is able to give the final approval? The error message when using the Java Platform Support extension is very annoying. |
The change is available in NB-21 and it would be released in next version of the extension |
|
Available in NB-21. So, closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch for gradle 8.5 added so that the misleading pop-up doesn't appear.
closes #29