Merge pull request #318 from lahodaj/jep-486

Disable SecurityManager

build.xml

@@ -65,6 +65,7 @@
             patches/remove-db.diff
             patches/nbjavac-not-required.diff
             patches/l10n-licence.diff
+            patches/no-security-manager-allow.diff
         </string>
         <filterchain>
             <tokenfilter delimoutput=" ">
@@ -109,6 +110,8 @@
         <move file="${lsp.build.dir}/platform/lib/nbexec" tofile="${lsp.build.dir}/platform/lib/nbexec.sh" />
         <replace file="${lsp.build.dir}/bin/nbcode.sh" token="/platform*/lib/nbexec" value="/platform*/lib/nbexec.sh"/>
         <replace file="${lsp.build.dir}/bin/nbcode.sh" token="basename &quot;$PRG&quot;" value="basename &quot;$PRG&quot; &quot;.sh&quot;"/>
+        <replace file="${lsp.build.dir}/platform/lib/nbexec.dll" token="java.security.manager" value="no.java.secur.manager" encoding="ISO-8859-1"/>
+        <replace file="${lsp.build.dir}/platform/lib/nbexec64.dll" token="java.security.manager" value="no.java.secur.manager" encoding="ISO-8859-1"/>
         <chmod file="${lsp.build.dir}/bin/nbcode.sh" perm="u+x" />
         <chmod file="${lsp.build.dir}/platform/lib/nbexec.sh" perm="u+x"/>
         <chmod file="${lsp.build.dir}/java/maven/bin/mvn.sh" perm="u+x" />

patches/no-security-manager-allow.diff

@@ -0,0 +1,13 @@
+diff --git a/platform/o.n.bootstrap/launcher/unix/nbexec b/platform/o.n.bootstrap/launcher/unix/nbexec
+index 1d6ad6e530..228b37cbe2 100755
+--- a/platform/o.n.bootstrap/launcher/unix/nbexec
++++ b/platform/o.n.bootstrap/launcher/unix/nbexec
+@@ -192,7 +192,7 @@ fi
+ # rename old heap dump to .old
+ mv "${userdir}/var/log/heapdump.hprof" "${userdir}/var/log/heapdump.hprof.old" > /dev/null 2>&1
+
+-jargs_without_clusters="$jargs -Djava.security.manager=allow"
++jargs_without_clusters="$jargs"
+ jargs="-Dnetbeans.dirs=\"${clusters}\" $jargs_without_clusters"
+
+ if [ -z "$cachedirspecified" ]; then

vscode/src/lsp/launchOptions.ts

@@ -53,7 +53,8 @@ const extraLaunchOptions = [
     "-J-XX:PerfMaxStringConstLength=10240",
     "--locale", l10n.nbLocaleCode(),
     "--start-java-language-server=listen-hash:0",
-    "--start-java-debug-adapter-server=listen-hash:0"
+    "--start-java-debug-adapter-server=listen-hash:0",
+    "-J-DTopSecurityManager.disable=true"
 ];
 
 const prepareUserConfigLaunchOptions = (): string[] => {