CSU-10 Add QPU information endpoints to ZMQ server #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfriel-oqc
requested review from
keriksson-rosenqvist,
owen-oqc,
hamidelmaazouz and
chemix-lunacy
as code owners
|
CLA Assistant Lite bot All Contributors have signed the CLA. |
|
I have read the Contributor License Agreement and I hereby accept the Terms. |
|
recheck |
keriksson-rosenqvist
previously requested changes
Jul 24, 2024
| from qat.qat import execute_with_metrics | ||
|
|
||
| class Messages(Enum): |
There was a problem hiding this comment.
I think some of this should live in a qat_rpc/utils.py module or even a central Server class, as it's not ZMQ specific, and there's potentially going to be other rpc methods in the future.
OK for now though.
jdavid-oqc
changed the title
|
I have read the Contributor License Agreement and I hereby accept the Terms. |
|
This is blocked waiting for the next QAT release which fixes the test failure seen above. The bug was actually in QAT not QAT-RPC. |
bgsach
reviewed
Oct 14, 2024
|
|
||
| from qat_rpc.utils.constants import PROMETHEUS_PORT | ||
| from qat_rpc.utils.metrics import MetricExporter, PrometheusReceiver | ||
| from qat_rpc.zmq.wrappers import ZMQClient, ZMQServer | ||
|
|
||
| qubit_count = 8 | ||
| qpu_couplings = [(i, j) for i in range(qubit_count) for j in range(qubit_count) if i != j] |
There was a problem hiding this comment.
There was previously no check that i!=j which caused flakeyness in the tests.
keriksson-rosenqvist
approved these changes
Oct 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For completion, pending hardware model changes for full error set and all QPU properties
See this issue for current design oqc-community/qat#127
currently being worked on