-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/repo setup #1
Conversation
Some generic comments on the structure;
|
agree with removing the src, done that. This isn't a testing structure that's agreed upon across software and seems like overkill for a stand alone library that doesn't have multiple packages or need integration testing in the same way cloud does. So not making this change here Equally for ruff, I have no opinion here, I'm going to leave this as is currently as it's the standard for the compiler team. But if they want it to be ruff or software team in general agrees to move everything over, then I'll change this no bother. Just not going to make that decision for another team |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for a first pass
Setting up repo:
Note, no dependencies, pure python outside of dev dependencies
includes backwards compatibility and tests for this