-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build: Setup initial hardhat compilations #423
base: master
Are you sure you want to change the base?
Conversation
Why removing |
This is good, I think it will be great if u do a walkthrough of the setup or hardhat overall in a learning session before merging this. |
Ah, my bad @haythem96 . It looked like an unused script. Will re-add. |
c309729
to
6b47969
Compare
166516a
to
1f2961f
Compare
Use this instead of the script: |
@antoncoding the output of the script that plugin runs is different than the What do you think @haythem96? Also, IIRC, by default |
Yes that's true, I think it is fine to keep the script, it is already working and doesn't need any maintenance even if we don't mainly use it, so I don't see a cons of keeping it. |
@haythem96 the issue I see with keeping is that it's very specific to |
I think we can keep it for now, and open another PR to modify all truffle script to hardhat, and then remove truffle as dev dependency |
Do not merge |
hardhat
as devDepartifacts
&cache
togitignore
compile
scriptcalculateContractBytecode
scriptcalculate-contract-bytecode
npm script