Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FSSDK-10616] overall test improvement #279

Merged
merged 6 commits into from
Sep 9, 2024
Merged

[FSSDK-10616] overall test improvement #279

merged 6 commits into from
Sep 9, 2024

Conversation

junaed-optimizely
Copy link
Contributor

@junaed-optimizely junaed-optimizely commented Sep 5, 2024 •
edited
Loading

Summary

  • Unit tests improvements of all the modules except "Client & Provider"
  • 33 new tests have been added
  • Improvements & deprecated API updates

Test plan

  • 33 new tests have been added along with improvement & deprecated API replacement

Issues

@junaed-optimizely junaed-optimizely changed the title [FSSDK-10616] experiment test improvement [FSSDK-10616] overall test improvement Sep 5, 2024
@junaed-optimizely junaed-optimizely marked this pull request as ready for review September 9, 2024 14:27
mikechu-optimizely
mikechu-optimizely approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/utils.spec.tsx Outdated Show resolved Hide resolved
mikechu-optimizely
mikechu-optimizely approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the added coverage. LGTM

@junaed-optimizely junaed-optimizely merged commit 5daff74 into master Sep 9, 2024
9 checks passed
@junaed-optimizely junaed-optimizely deleted the junaed/fssdk-10616-overall-test-coverage branch September 9, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikechu-optimizely mikechu-optimizely mikechu-optimizely approved these changes

Assignees

@junaed-optimizely junaed-optimizely

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@junaed-optimizely @mikechu-optimizely