refactor: less movement of code as the ref implementation

optimizely · Oct 8, 2024 · dfe1367 · dfe1367
1 parent c9047a0
commit dfe1367
Showing 1 changed file with 8 additions and 11 deletions.
diff --git a/OptimizelySDK/Bucketing/DecisionService.cs b/OptimizelySDK/Bucketing/DecisionService.cs
@@ -56,6 +56,7 @@ public bool DecisionBatchInProgress
                 {
                     SaveToUserProfileService();
                 }
+
                 _decisionBatchInProgress = value;
             }
         }
@@ -168,6 +169,13 @@ OptimizelyDecideOption[] options
                             UserProfileUtil.IsValidUserProfileMap(userProfileMap))
                         {
                             _userProfile = UserProfileUtil.ConvertMapToUserProfile(userProfileMap);
+                            decisionVariationResult =
+                                GetStoredVariation(experiment, _userProfile, config);
+                            reasons += decisionVariationResult.DecisionReasons;
+                            if (decisionVariationResult.ResultObject != null)
+                            {
+                                return decisionVariationResult.SetReasons(reasons);
+                            }
                         }
                         else if (userProfileMap == null)
                         {
@@ -181,17 +189,6 @@ OptimizelyDecideOption[] options
                                 reasons.AddInfo("The UserProfileService returned an invalid map."));
                         }
                     }
-
-                    if (_userProfile != null)
-                    {
-                        decisionVariationResult =
-                            GetStoredVariation(experiment, _userProfile, config);
-                        reasons += decisionVariationResult.DecisionReasons;
-                        if (decisionVariationResult.ResultObject != null)
-                        {
-                            return decisionVariationResult.SetReasons(reasons);
-                        }
-                    }
                 }
                 catch (Exception exception)
                 {