Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limit attributes/relationship diffs #5543

Open
wants to merge 6 commits into
base: stable
Choose a base branch
from

Conversation

ajtmccarty
Copy link
Contributor

@ajtmccarty ajtmccarty commented Jan 22, 2025

IFC-1141

changes to increase performance of diff calculations for attribute and relationship-level changes

  • previous PR broke the DiffNodePathsQuery out of the DiffAllPathsQuery. this PR does the same for the new DiffFieldPathsQuery.
  • changes to how we pass node UUID and attribute names/relationship identifiers into the diff calculation queries. used to use a big list of tuples: one for each node-attribute/relationship combination, which would be a lot of tuples for a large diff (>100,000). new approach is to use a dict/map b/c I figured out how to use one in the cypher query in place of the tuples list. testing indicates this did not affect performance, but it does make things easier to read and uses much less memory in Python

still need to do this one more time for the remaining DiffAllPathsQuery, but that should be a pretty significant performance improvement once get the query updated. will include the changelog with that final PR

@github-actions github-actions bot added the group/backend Issue related to the backend (API Server, Git Agent) label Jan 22, 2025
Copy link

codspeed-hq bot commented Jan 22, 2025

CodSpeed Performance Report

Merging #5543 will not alter performance

Comparing ajtm-01212025-limit-attrs-rels-diff (126d9db) with stable (ee9b3e7)

Summary

✅ 10 untouched benchmarks

@ajtmccarty ajtmccarty marked this pull request as ready for review January 23, 2025 01:31
@ajtmccarty ajtmccarty requested a review from a team January 23, 2025 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
group/backend Issue related to the backend (API Server, Git Agent)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant