Adding code for retrieving praise data for feedback #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregv
reviewed
Sep 27, 2024
common/utils/firebase.py
Outdated
| praise_list.append(doc_json) | ||
|
|
||
| # return the praise_list sorted in descending order by timestamp | ||
| return sorted(praise_list, key=lambda x: x["timestamp"], reverse=True) |
There was a problem hiding this comment.
Normally you want to rely on the database to sort since it's usually faster than doing it in code
AndrewHUNGNguyen
force-pushed
the
develop
branch
from
185c266 to
73ce95f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Adds an API to retrieve praise data written about a user of slack_user_id.
NOTE: Please do not merge this PR yet. I submitted this PR with the intent of feedback on work so far.
Type of change
Make sure you have