Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract user related logic into a users_service and user related routes into a users_views blueprint. #57

Merged
merged 13 commits into from
Apr 13, 2024
Merged

Extract user related logic into a users_service and user related routes into a users_views blueprint. #57

merged 13 commits into from
Apr 13, 2024

Conversation

rstackhouse
Copy link
Contributor

@rstackhouse rstackhouse commented Apr 9, 2024 •
edited
Loading

What does the PR do?

  • Extract user related logic into a users_service and user related routes into a users_views blueprint.
  • Introduce a data access layer that is storage technology agnostic
  • Introduce an in memory (backed up to xlsx, fed by csv) data provider to enable faster time to first PR by avoiding some of the overhead of getting a firestore emulator set up or cleaning up test data in the test firestore instance
  • Introduce a CLI for data rectification/manipulation
  • Remove services from Flask tree so that they can be consumed by both Flask and the CLI

Type of change

  • Breaking Change
  • Bug Fix
  • New Feature

Linked Issue

Related Issue: #56

Make sure you have

  • Pulled from the default branch
  • Documented your changes
  • Linked the Issue
  • Appointed a reviewer (if any)

gregv
gregv approved these changes Apr 13, 2024
View reviewed changes
Copy link
Contributor

@gregv gregv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉🎉🎉🎉🎉🤩🤩🤩🤩🙌

common/auth.py
api_key=PROPEL_AUTH_KEY
)

auth_user = current_user
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the thought for this @rstackhouse ?

db/db.py
db = InMemoryDatabaseInterface()
else:
from db.firestore import FirestoreDatabaseInterface
db = FirestoreDatabaseInterface()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice

model/hackathon.py
# "image_url": ""
# }

class Hackathon:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great add

@gregv gregv merged commit b0ef6d8 into opportunity-hack:develop Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregv gregv gregv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rstackhouse @gregv