Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge release/15.2 into dev #17695

Merged
merged 17 commits into from
Jan 23, 2025
Merged

Merge release/15.2 into dev #17695

merged 17 commits into from
Jan 23, 2025

Conversation

openprojectci
Copy link
Contributor

Created by GitHub action

myabc and others added 16 commits January 21, 2025 10:37
Increases the debounce to a more typical value (200-300ms) for a complex
web application. The current value (50ms) results in a large number of
unnecessary API requests - on installatons with large numbers of work
packages, this can lead to severe performance degradation.

This partially reverts a change made in commit b0fffbc

Signed-off-by: Alexander Brandon Coles <[email protected]>
Fixes `Type 'Timer' is not assignable to type 'number' error when
running `npm run test:watch`.

node typings for `setInterval()` specify `Timer` as its return type.
This patch explicitly calls the browser variant, which returns `number`.

See also TypeStrong/atom-typescript#1053
Implements a `debounceTimeMs` input property, allowing us to tweak the time in component subclasses and individual instances if need be.

This also reverts the zero initial debounce (also introduced in commit b0fffbc).
'seed' ppc64 bundle cache with state from release/15.2
Ensures feature specs run without debounce.
…-debounce

[#60649] Change op-autocompleter debounce to 250ms
@openprojectci openprojectci added the create-merge-release-into-dev-pr Mark auto created PRs that will be auto closed too label Jan 23, 2025
@dombesz dombesz self-requested a review January 23, 2025 10:37
@myabc
Copy link
Contributor

myabc commented Jan 23, 2025

@oliverguenther and I have both made recent changes to src/app/shared/components/autocompleter/op-autocompleter/op-autocompleter.component.ts (PR #17646, #17630). As such, I went ahead and merged in dev and resolved the conflicts since this component is still fresh in my mind. - @dombesz I saw you self-assigned. Hope that's ok?

@dombesz dombesz merged commit 549747b into dev Jan 23, 2025
11 checks passed
@dombesz dombesz deleted the merge-release/15.2-20250123033524 branch January 23, 2025 11:16
@dombesz dombesz removed their request for review January 23, 2025 11:16
@dombesz
Copy link
Contributor

dombesz commented Jan 23, 2025

Thanks @myabc !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
create-merge-release-into-dev-pr Mark auto created PRs that will be auto closed too
Development

Successfully merging this pull request may close these issues.

5 participants