⚠️ Bump catalogd to v0.36.0 #1434

m1kola · 2024-11-07T11:12:33Z

Description

There were some breaking changes in catalogd (operator-framework/catalogd#443) so this requires a manual bump.

Reviewer Checklist

API Go Documentation
Tests: Unit Tests (and E2E Tests, if appropriate)
Comprehensive Commit Messages
Links to related GitHub Issue(s)

netlify · 2024-11-07T11:12:50Z

✅ Deploy Preview for olmv1 ready!

Name	Link
🔨 Latest commit	`fe20381`
🔍 Latest deploy log	https://app.netlify.com/sites/olmv1/deploys/672ca2153643f5000830067c
😎 Deploy Preview	https://deploy-preview-1434--olmv1.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

m1kola · 2024-11-07T11:17:16Z

test/e2e/e2e_suite_test.go

-					Ref:          imageRef,
-					PollInterval: &metav1.Duration{Duration: time.Second},
+					Ref:                 imageRef,
+					PollIntervalMinutes: ptr.To(1),


Will probably have to bump timeouts in e2es because we went from 1 second to 1 minute.

So should not be here &metav1.Duration{Duration: time.Minute},

@camilamacedo86 no. It is no longer a *metav1.Duration field. It was changed in the linked PR here.

The value now accepts only minutes with the minimum of 1.

But CI seems to pass fine with the existing timeouts.

@m1kola Is there a way we can validate that this doesn't introduce flakiness into CI by timeouts not being sufficient? What are the existing timeouts?

@everettraven I was mostly worried about pulling like require.Eventually. We have some defaults here:

operator-controller/test/e2e/cluster_extension_install_test.go

Lines 38 to 39 in 26904a2

var pollDuration = time.Minute

var pollInterval = time.Second

But some tests can use own values in theory. Our pull interval for require.Eventually is usually quite low, so it should be good.

I think the more historic data from CI runs we get - the easier it will be asses if we need to increase something.

Signed-off-by: Mikalai Radchuk <[email protected]>

codecov · 2024-11-07T11:26:08Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.45%. Comparing base (22004fa) to head (fe20381).
Report is 3 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1434   +/-   ##
=======================================
  Coverage   73.45%   73.45%           
=======================================
  Files          42       42           
  Lines        3063     3063           
=======================================
  Hits         2250     2250           
  Misses        640      640           
  Partials      173      173

Flag	Coverage Δ
e2e	`55.20% <50.00%> (-0.20%)`	⬇️
unit	`52.59% <100.00%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

perdasilva

lgtm

camilamacedo86

/lgtm

… pollIntervalMinutes in ClusterCatalog spec In operator-framework#1434, the API was updated to use pollIntervalMinutes instead of pollInterval. This commit ensures all references are properly updated. See: https://github.com/operator-framework/operator-controller/pull/1434/files#diff-93b46b0715181c9cf397eed60862261b7839ff721599fcc393a393b9edea610bR57

…ith pollIntervalMinutes in ClusterCatalog spec and update documentation references In operator-framework#1434, the API was updated to use pollIntervalMinutes instead of pollInterval. This commit ensures that all references to pollInterval are correctly replaced with pollIntervalMinutes across the ClusterCatalog spec and relevant documentation. See: https://github.com/operator-framework/operator-controller/pull/1434/files#diff-93b46b0715181c9cf397eed60862261b7839ff721599fcc393a393b9edea610bR57

There were several intentional breaking changes in the API which are now included in v0.18.0 release. Our upgrade-e2e job need to be updated to make take the changes into account. Relevant PRs: * operator-framework#1439 * operator-framework#1434 Signed-off-by: Mikalai Radchuk <[email protected]>

There were several intentional breaking changes in the API which are now included in v0.18.0 release. Our upgrade-e2e job need to be updated to make take the changes into account. Relevant PRs: * #1439 * #1434 Signed-off-by: Mikalai Radchuk <[email protected]>

There were several intentional breaking changes in the API which are now included in v0.18.0 release. This commit mostly focuses on updating the documentation to reflect API changes. This includes making sure that snippets and example outputs match the current state of the project. Relevant PRs: * operator-framework#1439 * operator-framework#1434 Together with fixing snippets & outputs this fixes some rendering issues. Signed-off-by: Mikalai Radchuk <[email protected]>

There were several intentional breaking changes in the API which are now included in v0.18.0 release. This commit mostly focuses on updating the documentation to reflect API changes. This includes making sure that snippets and example outputs match the current state of the project. Relevant PRs: * operator-framework#1439 * operator-framework#1434 Signed-off-by: Mikalai Radchuk <[email protected]>

There were several intentional breaking changes in the API which are now included in v0.18.0 release. This commit mostly focuses on updating the documentation to reflect API changes. This includes making sure that snippets and example outputs match the current state of the project. Relevant PRs: * #1439 * #1434 Signed-off-by: Mikalai Radchuk <[email protected]>

There were several intentional breaking changes in the API which are now included in v0.18.0 release. This commit mostly focuses on updating the documentation to reflect API changes. This includes making sure that snippets and example outputs match the current state of the project. Relevant PRs: * operator-framework#1439 * operator-framework#1434 Signed-off-by: Mikalai Radchuk <[email protected]>

There were several intentional breaking changes in the API which are now included in v0.18.0 release. This commit mostly focuses on updating the documentation to reflect API changes. This includes making sure that snippets and example outputs match the current state of the project. Relevant PRs: * #1439 * #1434 Signed-off-by: Mikalai Radchuk <[email protected]>

There were several intentional breaking changes in the API which are now included in v0.18.0 release. This commit mostly focuses on updating the documentation to reflect API changes. This includes making sure that snippets and example outputs match the current state of the project. Relevant PRs: * operator-framework#1439 * operator-framework#1434 Signed-off-by: Mikalai Radchuk <[email protected]>

There were several intentional breaking changes in the API which are now included in v0.18.0 release. This commit mostly focuses on updating the documentation to reflect API changes. This includes making sure that snippets and example outputs match the current state of the project. Relevant PRs: * #1439 * #1434 Signed-off-by: Mikalai Radchuk <[email protected]>

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 7, 2024

m1kola commented Nov 7, 2024

View reviewed changes

Bump catalogd to v0.36.0

fe20381

Signed-off-by: Mikalai Radchuk <[email protected]>

m1kola force-pushed the catalogd_bump branch from 3be9cf5 to fe20381 Compare November 7, 2024 11:18

m1kola marked this pull request as ready for review November 7, 2024 11:37

m1kola requested a review from a team as a code owner November 7, 2024 11:37

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 7, 2024

m1kola requested a review from everettraven November 7, 2024 12:16

perdasilva approved these changes Nov 7, 2024

View reviewed changes

camilamacedo86 reviewed Nov 7, 2024

View reviewed changes

openshift-ci bot assigned camilamacedo86 Nov 7, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2024

joelanford added this pull request to the merge queue Nov 7, 2024

LalatenduMohanty approved these changes Nov 7, 2024

View reviewed changes

Merged via the queue into operator-framework:main with commit 8cd4a8c Nov 7, 2024
20 checks passed

m1kola deleted the catalogd_bump branch November 7, 2024 14:50

camilamacedo86 mentioned this pull request Nov 11, 2024

🐛 Fix follow-up for bumping catalogd to v0.36.0: Replace pollInterval for pollIntervalMinutes #1442

Closed

m1kola mentioned this pull request Nov 12, 2024

🌱 Fix upgrade-e2e CI job #1445

Merged

4 tasks

m1kola mentioned this pull request Nov 12, 2024

📖 Fix docs: "Getting Started" and "Tutorials" #1443

Merged

7 tasks

m1kola mentioned this pull request Nov 14, 2024

📖 Fix docs: "How to" section #1463

Merged

4 tasks

m1kola mentioned this pull request Nov 15, 2024

📖 Fix docs: "Conceptual Guides" section #1473

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

⚠️ Bump catalogd to v0.36.0 #1434

⚠️ Bump catalogd to v0.36.0 #1434

m1kola commented Nov 7, 2024

netlify bot commented Nov 7, 2024 •

edited

Loading

m1kola Nov 7, 2024

camilamacedo86 Nov 7, 2024

m1kola Nov 7, 2024

m1kola Nov 7, 2024

everettraven Nov 7, 2024

m1kola Nov 7, 2024

codecov bot commented Nov 7, 2024 •

edited

Loading

perdasilva left a comment

camilamacedo86 left a comment

	var pollDuration = time.Minute
	var pollInterval = time.Second

⚠️ Bump catalogd to v0.36.0 #1434

⚠️ Bump catalogd to v0.36.0 #1434

Conversation

m1kola commented Nov 7, 2024

Description

Reviewer Checklist

netlify bot commented Nov 7, 2024 • edited Loading

✅ Deploy Preview for olmv1 ready!

m1kola Nov 7, 2024

Choose a reason for hiding this comment

camilamacedo86 Nov 7, 2024

Choose a reason for hiding this comment

m1kola Nov 7, 2024

Choose a reason for hiding this comment

m1kola Nov 7, 2024

Choose a reason for hiding this comment

everettraven Nov 7, 2024

Choose a reason for hiding this comment

m1kola Nov 7, 2024

Choose a reason for hiding this comment

codecov bot commented Nov 7, 2024 • edited Loading

Codecov Report

perdasilva left a comment

Choose a reason for hiding this comment

camilamacedo86 left a comment

Choose a reason for hiding this comment

netlify bot commented Nov 7, 2024 •

edited

Loading

codecov bot commented Nov 7, 2024 •

edited

Loading