(HOLD - WIP) ⚠️ Replace kube-rbac-proxy with controller-runtime metrics authentication/authorization #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #460 +/- ##
==========================================
- Coverage 38.23% 37.71% -0.53%
==========================================
Files 15 15
Lines 1224 1241 +17
==========================================
Hits 468 468
- Misses 706 723 +17
Partials 50 50 ☔ View full report in Codecov by Sentry. |
camilamacedo86
force-pushed
the
replace-kube-rbac-proxy
branch
3 times, most recently
from
befdef7
to
8ca7c1d
Compare
camilamacedo86
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
camilamacedo86
force-pushed
the
replace-kube-rbac-proxy
branch
from
0ee7199
to
3183153
Compare
camilamacedo86
changed the title
openshift-ci
bot
added
the
do-not-merge/work-in-progress
…n/authorization This commit removes the use of the kube-rbac-proxy image and replaces it with metrics authentication/authorization provided by controller-runtime. The kube-rbac-proxy image is deprecated and will no longer be maintained, which introduces risks to production environments. For more details, see: kubernetes-sigs/kubebuilder#3907 Key changes: - Updated to configure metrics server options with secure authentication/authorization using controller-runtime filters. - Added support for disabling HTTP/2 by default to mitigate vulnerabilities (e.g., HTTP/2 Stream Cancellation CVE). - Removed the kube-rbac-proxy container from deployment configurations. - Updated RBAC files to include metrics-specific roles and bindings, ensuring secure access to metrics. This aligns with best practices for security and simplifies the metrics setup by leveraging built-in capabilities of controller-runtime.
camilamacedo86
force-pushed
the
replace-kube-rbac-proxy
branch
from
3183153
to
4ad7f35
Compare
camilamacedo86
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
camilamacedo86
changed the title
camilamacedo86
commented
Nov 20, 2024
| # More info: https://book.kubebuilder.io/reference/metrics.html | ||
| - metrics_auth_role.yaml | ||
| - metrics_auth_role_binding.yaml | ||
| - metrics_reader_role.yaml |
There was a problem hiding this comment.
TODO: revert the name changed here.
We need to keep the same
camilamacedo86
commented
Nov 20, 2024
| roleRef: | ||
| apiGroup: rbac.authorization.k8s.io | ||
| kind: ClusterRole | ||
| name: proxy-role | ||
| name: metrics-auth-role |
There was a problem hiding this comment.
TODO: revert those changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the use of the kube-rbac-proxy image and replaces it with metrics authentication/authorization provided by controller-runtime. The kube-rbac-proxy image is deprecated and will no longer be maintained, which introduces risks to production environments. For more details, see: kubernetes-sigs/kubebuilder#3907
Key changes: