Disregard route if update is a subnet of tun's address #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the tun_ip is derived from dns_block, set the tun's address prefix length equal to dns_block prefix length. Then ignore any route updates that are a subnet of the tun's address. This becomes helpful when large number of DNS intercepts are employed (say wildcard), each causing a /32 route to be added. Signed-off-by: Tom Carroll <[email protected]>
tomc797
force-pushed
the
feature/disregard_route_updates_that_subnet_tun_address
branch
from
5c50bdd
to
87a4f73
Compare
|
Thanks for taking a stab at this. This has been on our minds for a while now (#474). Ideally the matching routes would be caught at the tunneler-sdk layer (probably in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the
tun_ipis derived fromdns_block, set thetun's address prefix length equal todns_blockprefix length. Then ignore any route updates that are a subnet of thetun's address. This becomes helpful when large number of DNS intercepts are employed (say wildcard), each causing a /32 route to be added.