Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automate daily tests of ZIM behavior - Youtube only for now #351

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Automate daily tests of ZIM behavior - Youtube only for now #351

merged 1 commit into from
Aug 7, 2024

Conversation

benoit74
Copy link
Collaborator

Fix #330

@benoit74 benoit74 self-assigned this Jul 22, 2024
@benoit74 benoit74 force-pushed the automated_daily_tests branch from e9b622a to 5ed03e5 Compare July 22, 2024 07:17
@benoit74 benoit74 mentioned this pull request Jul 22, 2024
Open
@benoit74 benoit74 marked this pull request as ready for review July 22, 2024 07:21
@benoit74 benoit74 requested a review from rgaudin July 22, 2024 07:21
rgaudin
rgaudin approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except it all relies on if not chrome_driver.execute_script("return arguments[0].paused === false", video): which is not obvious (what's arguments[0]?) so it mandates a comment somewhere IMO

@benoit74 benoit74 force-pushed the automated_daily_tests branch from 5ed03e5 to 6d078c4 Compare August 7, 2024 10:34
@benoit74 benoit74 merged commit 1ea533c into main Aug 7, 2024
5 checks passed
@benoit74 benoit74 deleted the automated_daily_tests branch August 7, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgaudin rgaudin rgaudin approved these changes

Assignees

@benoit74 benoit74

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement daily automated testing of Youtube player
2 participants
@benoit74 @rgaudin