Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propose the 'Not set' value only if flag is not required #38

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Propose the 'Not set' value only if flag is not required #38

merged 1 commit into from
Oct 6, 2023

Conversation

benoit74
Copy link
Collaborator

@benoit74 benoit74 commented Oct 6, 2023

Changes

  • In the UI, when the flag type is "StringEnum", the "Not set" option is not shown in the combobox when the flag is required

@benoit74 benoit74 requested a review from rgaudin October 6, 2023 11:14
@benoit74 benoit74 mentioned this pull request Oct 6, 2023
Merged
rgaudin
rgaudin approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rgaudin rgaudin merged commit b89ac79 into main Oct 6, 2023
2 checks passed
@rgaudin rgaudin deleted the string_enum branch October 6, 2023 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgaudin rgaudin rgaudin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benoit74 @rgaudin