Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop checking main entry processability when it is already found #425

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Stop checking main entry processability when it is already found #425

merged 2 commits into from
Nov 27, 2024

Conversation

benoit74
Copy link
Collaborator

Fix #424

@benoit74 benoit74 self-assigned this Nov 25, 2024
@benoit74 benoit74 marked this pull request as ready for review November 25, 2024 21:43
@rgaudin
Copy link
Member

rgaudin commented Nov 26, 2024

Forgot to request review?

@benoit74 benoit74 marked this pull request as draft November 26, 2024 13:20
@benoit74
Copy link
Collaborator Author

Nope, forgot to move back to draft, I would like to add tests to the test website first ^^

@benoit74 benoit74 marked this pull request as ready for review November 26, 2024 14:29
@benoit74 benoit74 requested a review from rgaudin November 26, 2024 14:29
@benoit74
Copy link
Collaborator Author

Really ready this time^^

rgaudin
rgaudin approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benoit74 benoit74 merged commit 5040eee into main Nov 27, 2024
6 checks passed
@benoit74 benoit74 deleted the double_slash_main branch November 27, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgaudin rgaudin rgaudin approved these changes

Assignees

@benoit74 benoit74

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

thales_doc is considered unprocessable by mistake
2 participants
@benoit74 @rgaudin