-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to libzim9 #1838
base: main
Are you sure you want to change the base?
Move to libzim9 #1838
Conversation
@kelvinhammond Thank you again for being back on this super-important PR. Just wanted to ask what is the status? Do you think this is ready to review? Do we just need to release latest node-libzim to get the CI passing? |
CI build fails but looks good to review to me @kelson42 |
@kelvinhammond I had a look and there a bit of work related to links and content. I will work on this on your PR and come back to you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a look to the PR. Here are my comments:
- MWoffliner builds a ZIM file, which is a good start
- The ZIM file built is incorrect by many way, you can see it easily if you open it with
kiwix-serve
- One problem is that new ZIM flies (using latest libzim) do handle the ZIM namespaces differently. They were before open and free to use and now they are hidden behind the scene in the libzim. We did that to basically how the writting of content for the ZIM developer in the
C
namespace. This means that everything should be in theC
namespace now (transparent for MWoffliner) whereas in the past we have put the images in theI
namespace and the article in theA
namespace. All of this has a few implication how we writte the content and how we create the links in the HTML. I could handle this kind of problem. - The other problem is that it seems the libzim creates corrupted content. I have tried with the "Animation" article in the Wikipedia in English. It seems that many images are corrupted, for example
FelixTheCat-1919-FelineFollies_silent.ogv.180p.vp9.webm
which is now not a valid webm file. I suspect the reason is that you write anything through theStringItem
which is IMO not appropriate for blobs.
IMO we should really fix the problem with blobs in priority.
This pull request has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions. |
Data is lost on buffer.toString
eb2cc7a
to
50236af
Compare
We should now rebase on latest HEAD now that |
@audiodude Please have a look to this PR, this has been done before the rearchitecturing of Fall 2023, but otherwise most of the code should be OK and just to be taken. |
No description provided.