-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create dedicated Docker 'scraper' user #1321
base: main
Are you sure you want to change the base?
Conversation
@rgaudin This is an attempt to make our Docker a bit more secure. But this has for direct consequence that the mounted volumed should be writeable by the new user |
This pull request has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions. |
Codecov Report
@@ Coverage Diff @@
## master #1321 +/- ##
=======================================
Coverage 69.42% 69.42%
=======================================
Files 26 26
Lines 2401 2401
Branches 469 469
=======================================
Hits 1667 1667
Misses 569 569
Partials 165 165 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- most rootless images defaults to user
1001
as this is what a regular distro would create so it has more chances to work out of the box. - rootless implies choosing a user so uid and gid might be anything
/data
is gonna be mounted and there's no guarantee you'll be able to write on it. You may want to check that in entrypoint to provide a quick and clear feedback should permissions not be adequate. I don't know how quick and clear mwoffliner is gonna fail in this case.- README may need to be updated to inform about write requirements on mounted volume source.
This pull request has been automatically marked as stale because it has not had recent activity. It will be now be reviewed manually. Thank you for your contributions. |
Fixes #995