fix(shared): Don't accept inconsistent encoding lengths in IdCred KIDs

openwsn-berkeley · Nov 25, 2024 · 978f8e1 · 978f8e1
1 parent 516eee9
commit 978f8e1
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/shared/src/cred.rs b/shared/src/cred.rs
@@ -83,7 +83,7 @@ impl IdCred {
                     .map_err(|_| EDHOCError::CredentialTooLongError)? // TODO: how to avoid map_err overuse?
             }
             // kid that has been encoded as CBOR byte string
-            &[0x41, x, ..] if !Self::bstr_representable_as_int(x) => {
+            &[0x41, x] if !Self::bstr_representable_as_int(x) => {
                 let mut bytes = BufferIdCred::new_from_slice(&[0xa1, KID_LABEL])
                     .map_err(|_| EDHOCError::CredentialTooLongError)?;
                 bytes