change introduction to feedback emails

[Alex-Jordan]

This changes some things about the opening lines to a feedback email.

This may be controversial. I'm happy to make changes. This started out simply as removing the double space that was there, but then I kept going. I think it's nicer this way, but not opposed to further changes or retractions.

[Alex-Jordan]

Here is what an email looks like with this:

This message was generated by WeBWorK at
https://webwork-hosting.runestone.academy/webwork2
in response to a request from Alex Jordan (alex.jordan) at
162.158.63.39:20448

To visit the page from which the user sent feedback, go to:
https://webwork-hosting.runestone.academy/webwork2/Active-Calculus-Demo/1_1-How_do_we_measure_velocity_Exercises/1?effectiveUser=alex.jordan&showSolutions=1&showCorrectAnswers=1&displayMode=MathJax&showHints=1&showOldAnswers=1

Alex Jordan (alex.jordan) wrote:


I need help with this exercise!

Maybe the ***** The feedback message: ***** part should be retained. I don't know.

What is supposed to be the point of the IP address? When I initiated this message, I was at home using PCC's VPN, logged in to a course on the Runestone WW server. I looked up this IP address and it's somewhere in New Jersey. I turned off the VPN and then I get the same IP address, so it's not some mysterious thing about PCC's VPN. Also, it is not the IP address for the Runestone WW server.

[somiaj]

I would be okay with simplifying the whole first paragraph. If someone prefers to include the users ip, maybe an option to not include it would be nice. I was thinking along the lines of of Message from <user> using WeBWorK at <course url>.

[drgrice1]

This looks fine to me.

[drgrice1]

I like the addition of the user name and login id to the email message. I would be fine with removing the remote host and port from the email. I doubt that is actually useful to anyone in reality. Remote host ip addresses rarely are anymore.

[drgrice1]

Another idea would be to move the host ip and port down with the data about the user at the end of the email.

[somiaj]

Here are some more ideas, modify what you think is best, just thinking of other things that could be updated.

If wanting to keep the ip address, maybe add that to the $mail{feedbackVerbosity}='debug' blocks, but omit it in other cases.

Also since you are editing this and the user's id and full name is now included by default, you might want to update the output for both standard and debug output. The format_user data also gives the user id, full name, and email (since it is the from: field), so consider if duplicated output is useful (or maybe only include the user id or full name in your changes as the user data will include the full set of info). You may also want to update the other headers like $msg .= "***** Data about the user: *****\n\n"; to match the changes you have already made as well.