Switch to using the latest Perl::Tidy (version 20240903) alternate approach. #2633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drgrice1
force-pushed
the
perltidy-update-alt
branch
2 times, most recently
from
4c586a8 to
7d2b14c
Compare
This commit just makes the changes in the scripts, but does not yet run perltidy with the new setup. That will be done in the next commit. A new `--valign-signed-numbers` option has been added in the version of Perl::Tidy and is the default. That option has been disabled to reduce the number of code changes. Although it only changes one line of the webwork2 code. It changes a lot more in the pg code. Note that the `bin/dev_scripts/run-perltidy.pl` script now insists on this specific version of perltidy instead of this version or newer. This is because every time a new version of perltidy comes out, it changes things. So developers really need to be using the same version or it will not be consistent with the github workflow result. Also, the version requirement in the check_modules.pl script has been removed. Only developers need a specific version of perltidy. Those running webwork2 can use other versions. This is only used for formatting problems in the PG problem editor, and using other versions may result in slightly different formatting there, but that is not so consequential that we need to require a specific version. Note that this change depends on the corresponding pg pull request, because in that pull request the `-vxl='q'` option has been removed. Otherwise version 20220613 or newer of perltidy would still be needed.
drgrice1
force-pushed
the
perltidy-update-alt
branch
from
7d2b14c to
72f26b0
Compare
pstaabp
approved these changes
Dec 10, 2024
|
Closing as we went with #2632. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new
--valign-signed-numbersoption has been added in the version of Perl::Tidy and is the default. That option has been disabled to reduce the number of code changes. Although it only changes one line of the webwork2 code. It changes a lot more in the pg code.The
bin/dev_scripts/run-perltidy.plscript now insists on this specific version of perltidy instead of this version or newer. This is because every time a new version of perltidy comes out, it changes things. So developers really need to be using the same version or it will not be consistent with the github workflow result.Also, the version requirement in the check_modules.pl script has been removed. Only developers need a specific version of perltidy. Those running webwork2 can use other versions. This is only used for formatting problems in the PG problem editor, and using other versions may result in slightly different formatting there, but that is not so consequential that we need to require a specific version. Note that this change depends on the corresponding pg pull request (openwebwork/pg#1146), because in that pull request the
-vxl='q'option has been removed. Otherwise version 20220613 or newer of perltidy would still be needed.The first commit makes the changes for the switch to the new version, and the second commit is merely the result of running
perltidywith the new version and rules.