Hotfix: Prevent error when adding new course. #2623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When adding a new course if the initial instructor entered into the add course form has the same user ID as a user in the course non-student users, sets, and achievements are being copied from, this user gets assigned to sets and achievements twice, causing an error. This skips assigning the initial user to the original sets they may have been assigned to and will always assign the initial user to all sets and achievements, so no error occurs.
Alex-Jordan
approved these changes
Nov 16, 2024
drgrice1
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding a new course if the initial instructor entered into the add course form has the same user ID as a user in the course non-student users, sets, and achievements are being copied from, this user gets assigned to sets and achievements twice, causing an error.
This skips assigning the initial user to the original sets they may have been assigned to and will always assign the initial user to all sets and achievements, so no error occurs.
This will be fixed as part of #2619 in develop, so there is only a hotfix PR for main.