Change to more reasonable dates in the Student Orientation set definition. #2599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drgrice1
force-pushed
the
reasonable-dates-for-student-orientation
branch
from
70b033e to
09fd2c7
Compare
…tion. Using a date that is not in this century for the reduced scoring date, due date, and answer date leads to confusion due to the some limited default date display formats. Some not so intelligent locales like to only use the last two digits for the year. For example, in the "en" locale the date displays as "12/31/24, 11:59 PM" in the date picker. Looking at that you might think the date is set for the end of this year (at the time of this writing this year is 2024) instead of 100 years from now. Initially, I though that the "en" US locale was the only one with this issue, but about half of the supported languages have the same problem. This was the issue that was occurring when I was looking at the date picker during our meeting this week, and had nothing to do with the reduced scoring date being set.
somiaj
approved these changes
Oct 25, 2024
There was a problem hiding this comment.
Looks good.
I was almost wondering if just removing these dates altogether would be an option, that way default values are used for the course vs some preset value. I tested this out and it seems that if the .def file was missing these three lines, it would work to import the file, but it also spits out a few warnings, which probably isn't ideal. Just a thought.
As discussed in the development meeting.
drgrice1
force-pushed
the
reasonable-dates-for-student-orientation
branch
from
09fd2c7 to
10c0db2
Compare
dlglin
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a date that is not in this century for the reduced scoring date, due date, and answer date leads to confusion due to some limited default date display formats. Some not so intelligent locales like to only use the last two digits for the year. For example, in the "en" locale the date displays as "12/31/24, 11:59 PM" in the date picker. Looking at that you might think the date is set for the end of this year (at the time of this writing this year is 2024) instead of 100 years from now.
Initially, I though that the "en" US locale was the only one with this issue, but about half of the supported languages have the same problem.
This was the issue that was occurring when I was looking at the date picker during our meeting this week, and had nothing to do with the reduced scoring date being set.
Edit: This now uses December 31, 2045 as discussed in the development meeting.