Remove the special case in the getThirdPartyAssetURL method for MathQuill.
#2596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somiaj
approved these changes
Oct 8, 2024
drgrice1
force-pushed
the
remove-old-mathquill-asset-case
branch
from
7f30c6d to
7cf196a
Compare
drgrice1
force-pushed
the
remove-old-mathquill-asset-case
branch
from
7cf196a to
fba77cd
Compare
…hQuill.
That special handling is no longer needed now that MathQuill is
installed via npm from the npm repositories. Furthermore, jsdelivr
provides the files from the package that can be used when the
`$options{thirdPartyAssetsUseCDN}` option is set to 1.
drgrice1
force-pushed
the
remove-old-mathquill-asset-case
branch
from
fba77cd to
917732a
Compare
pstaabp
approved these changes
Nov 12, 2024
pstaabp
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That special handling is no longer needed now that MathQuill is installed via npm from the npm repositories. Furthermore, jsdelivr provides the files from the package that can be used when the
$options{thirdPartyAssetsUseCDN}option is set to 1.