For LTI 1.3 only consider roles in the context for automatically created users. #2591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drgrice1
force-pushed
the
lti-use-context-role-only
branch
2 times, most recently
from
2581977 to
3da88f0
Compare
|
This also relates to #2587, which should be closed if this is merged. |
|
@Alex-Jordan: Thanks for referencing the issue. I was looking for that when I made this pull request, but for some reason, I couldn't find it. |
drgrice1
force-pushed
the
lti-use-context-role-only
branch
from
3da88f0 to
d6ba13c
Compare
drgrice1
force-pushed
the
lti-use-context-role-only
branch
from
d6ba13c to
ab934b0
Compare
drgrice1
force-pushed
the
lti-use-context-role-only
branch
from
ab934b0 to
0302aca
Compare
Alex-Jordan
approved these changes
Nov 13, 2024
drgrice1
force-pushed
the
lti-use-context-role-only
branch
from
0302aca to
02a1611
Compare
…ted users. This is to fix the issue discussed in https://webwork.maa.org/moodle/mod/forum/discuss.php?d=8565#p21514. If someone needs the institution roles, then the new $LTI{v1p3}{AllowInstitutionRoles} option defined in conf/authen_LTI_1_3 can be set to 1, and then those roles will also be considered.
drgrice1
force-pushed
the
lti-use-context-role-only
branch
from
02a1611 to
90f6209
Compare
somiaj
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the context and institution roles are are considered. This makes it so that only context roles are considered by default. If someone needs the institution roles, then the new $LTI{v1p3}{AllowInstitutionRoles} option defined in conf/authen_LTI_1_3 can be set to 1, and then those roles will also be considered. For now system roles are always ignored (as they were before).
This is to fix the issue discussed in https://webwork.maa.org/moodle/mod/forum/discuss.php?d=8565#p21514.