-
-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use reduced credit when checking if problem is correct in Grades table. #2584
Use reduced credit when checking if problem is correct in Grades table. #2584
Conversation
769e023
to
de37291
Compare
de37291
to
ab0debc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good. I only have a wording suggestion on the POD change for the grade_set
method.
I am debating if it would be better if the grade_set
handled the compute_unreduced_score
computation, and instead of returning the array of problem records, only returned an array of the unreduced scores. I suppose leave it as it is for now, and if the unreduced score becomes something used more frequently elsewhere in combination with the grade_set
results, then we can change it at that time.
ab0debc
to
d96dc80
Compare
POD updated as suggested. |
d96dc80
to
9c4c092
Compare
It appears that #2617 modifies Also should I include the suggested update in #2627, so non-zero grades to unattempted problems are also shown in the grade table? |
You can add the non zero change to this. |
Also if you update the |
9c4c092
to
81bd67d
Compare
Okay updated my changes to |
Looks good. In theory it shouldn't matter on the merge order of this or #2617. Assuming the other changes are far enough away. Usually more than 5 lines away is enough. |
Use compute_unreduced_grade to determine if a problem is correct or not on the student's grade table to highlight correct problems.
81bd67d
to
1b766f8
Compare
Use
compute_unreduced_grade
to determine if a problem is correct or not on the student's grade table to highlight correct problems.