Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use reduced credit when checking if problem is correct in Grades table. #2584

Merged

Conversation

somiaj
Copy link
Contributor

@somiaj somiaj commented Sep 28, 2024

Use compute_unreduced_grade to determine if a problem is correct or not on the student's grade table to highlight correct problems.

@somiaj somiaj force-pushed the grades-correct-use-reduced-cred branch 2 times, most recently from 769e023 to de37291 Compare September 28, 2024 18:19
@somiaj somiaj force-pushed the grades-correct-use-reduced-cred branch from de37291 to ab0debc Compare October 25, 2024 16:02
Copy link
Member

@drgrice1 drgrice1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good. I only have a wording suggestion on the POD change for the grade_set method.

I am debating if it would be better if the grade_set handled the compute_unreduced_score computation, and instead of returning the array of problem records, only returned an array of the unreduced scores. I suppose leave it as it is for now, and if the unreduced score becomes something used more frequently elsewhere in combination with the grade_set results, then we can change it at that time.

lib/WeBWorK/Utils/Sets.pm Outdated Show resolved Hide resolved
@somiaj somiaj force-pushed the grades-correct-use-reduced-cred branch from ab0debc to d96dc80 Compare November 13, 2024 04:40
@somiaj
Copy link
Contributor Author

somiaj commented Nov 13, 2024

POD updated as suggested.

@somiaj somiaj force-pushed the grades-correct-use-reduced-cred branch from d96dc80 to 9c4c092 Compare November 13, 2024 05:46
@somiaj
Copy link
Contributor Author

somiaj commented Nov 21, 2024

It appears that #2617 modifies grade_set in a similar way to what is needed in this PR. Since this is a much smaller change, this should be delayed until after #2617 is merged, and I can update all the conflicts. I should be able to just use the changes to grade_set directly and only have to update the grades table.

Also should I include the suggested update in #2627, so non-zero grades to unattempted problems are also shown in the grade table?

@drgrice1
Copy link
Member

You can add the non zero change to this.

@drgrice1
Copy link
Member

Also if you update the grade_set method so that your changes are identical to the change in #2617, then it shouldn't conflict.

@somiaj somiaj force-pushed the grades-correct-use-reduced-cred branch from 9c4c092 to 81bd67d Compare November 21, 2024 23:59
@somiaj
Copy link
Contributor Author

somiaj commented Nov 22, 2024

Okay updated my changes to grade_set to match #2617, and this also will show non-zero status on unattempted problems.

@drgrice1
Copy link
Member

Looks good. In theory it shouldn't matter on the merge order of this or #2617. Assuming the other changes are far enough away. Usually more than 5 lines away is enough.

Use compute_unreduced_grade to determine if a problem is correct or not
on the student's grade table to highlight correct problems.
@somiaj somiaj force-pushed the grades-correct-use-reduced-cred branch from 81bd67d to 1b766f8 Compare November 23, 2024 01:43
@Alex-Jordan Alex-Jordan merged commit 1ea1bb6 into openwebwork:develop Nov 24, 2024
2 checks passed
@somiaj somiaj deleted the grades-correct-use-reduced-cred branch November 24, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants