Delay file creation when a new file is created in the file manager. #2339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drgrice1
force-pushed
the
file-manager-new-file-delay-create
branch
from
dd8f462 to
aa71868
Compare
Instead of creating the file when the new file confirmation page is submitted, create the file when "Save" (or "Save As") is clicked from the edit page that opens next. This was requested in issue openwebwork#2326. Also, don't focus the `name` input on the edit page. That is a bit annoying. Only focus that input on the confirmation page. That is the only page that has a `data` input.
drgrice1
force-pushed
the
file-manager-new-file-delay-create
branch
from
aa71868 to
9e37b12
Compare
|
Works as described, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of creating the file when the new file confirmation page is submitted, create the file when "Save" (or "Save As") is clicked from the edit page that opens next.
This was requested in issue #2326.
Also, don't focus the
nameinput on the edit page. That is a bit annoying. Only focus that input on the confirmation page. That is the only page that has adatainput.