Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip over hidden folders and files in the library browser #2331

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

Alex-Jordan
Copy link
Contributor

Chemistry faculty here have a library they manage with git. It has a .git folder at the top level that shows up in the library browser's list of folders containing PG files (if you click the button to view this library). It could be managed like the OPL, with an intermediate folder, but this seems like a good change anyway. Namely, filter out any files or folders that start with a dot.

Copy link
Member

@drgrice1 drgrice1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine.

This is another place where Mojo::File usage could simplify things quite a bit.

Also, I think that the =library-no-combine, =library-combine-up, and =library-ignore crap should be removed. I don't know why it was thought that it would be a good idea to use directories by those names to implement this odd behavior that is not documented anywhere.

@Alex-Jordan
Copy link
Contributor Author

I think that the =library-no-combine, =library-combine-up, and =library-ignore crap should be removed

I agree. Unfortunately I just brought this to someone's attention last week, so I know of one person using it. No big deal if they have to find another way. They are using it so that a folder with testing .pg files within their personal library tree won't appear.

Copy link
Member

@pstaabp pstaabp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@drgrice1
Copy link
Member

drgrice1 commented Mar 5, 2024

This can be merged.

@drgrice1 drgrice1 merged commit e116c13 into openwebwork:develop Mar 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants