Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a patch for the dvisvgm issue observed in https://github.com/openwebwork/pg/issues/1023. #2330

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

drgrice1
Copy link
Member

@drgrice1 drgrice1 commented Feb 22, 2024

This patch is applied in the docker build.

It can be applied on your server with the command
sudo patch -p1 -d / < /opt/webwork/webwork2/docker-config/pgfsys-dvisvmg-bbox-fix.patch

Note this patch is specific to Ubuntu 22.04, so don't try it on other versions of Ubuntu or other linux distributions (or other operating systems).

This was the change made in pgf-tikz/pgf#1276 that was merged into the master branch of the pgf-tikz latex package on October 23, 2023 that fixes the issue reported in pgf-tikz/pgf#1275.

The dependence on File::Copy::Recursive module was added in openwebwork#2172, but
not added to the docker build.

Start using node 20 in the docker build.  The node 16 install script
from nodesource is deprecated, and they have imposed a 60 second install
delay when you use it.

Fix the ownership on the courses directory and admin course directory
when the docker entrypoint runs.  Fixing the ownership on the courses
directory and admin course directory will not cause any slow down to the
execution of that script.  It is not a recursive ownership change, just
two directories for which ownership is changed which is super fast.
This patch is applied in the docker build.

It can be applied on your server with the command
`sudo patch -p1 -d / < /opt/webwork/webwork2/docker-config/pgfsys-dvisvmg-bbox-fix.patch.patch`

Note this patch is specific to Ubuntu 22.04, so don't try it on other
versions of Ubuntu or other linux distributions.

This was the change made in pgf-tikz/pgf#1276
that was merged into the master branch of the to the pgf-tikz latex
package on October 23, 2023 that fixes the issue reported in
pgf-tikz/pgf#1275.
@drgrice1 drgrice1 force-pushed the dvisvgm-pgfsys-driver-patch branch from 59141ee to 16a2c3f Compare February 22, 2024 21:23
@drgrice1
Copy link
Member Author

In testing this I realized the docker build is broken, and has some other issues. So this pull request now fixes those things. These changes are in the first commit. The second commit is what this originally did.

The changes are:

The dependence on File::Copy::Recursive module was added in #2172, but not added to the docker build.

Start using node 20 in the docker build. The node 16 install script from nodesource is deprecated, and they have imposed a 60 second install delay when you use it.

Fix the ownership on the courses directory and admin course directory when the docker entrypoint runs. Fixing the ownership on the courses directory and admin course directory will not cause any slow down to the execution of that script. It is not a recursive ownership change, just two directories for which ownership is changed which is super fast.

Copy link
Contributor

@somiaj somiaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested that the patch also correctly applies in Debian bookworm, and fixes the issue.

Note, you have .patch.patch in the above command, so copy/pasting it will fail.

@drgrice1
Copy link
Member Author

Thanks. I fixed the patch command.

@Alex-Jordan Alex-Jordan merged commit 75f7716 into openwebwork:develop Feb 23, 2024
2 checks passed
@drgrice1 drgrice1 deleted the dvisvgm-pgfsys-driver-patch branch February 23, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants