Fix an issue that can cause LTI 1.3 grade passback to fail when called from the job queue. #2319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It sounds like this is unlikely to explain why I have not been able to get grade passback working with D2L, because one should expect that most of the time, that access token should be present and not expired. Is that right? Or is it possible this plays into the issues I had with grade passback and LTI 1.3? |
|
It is probably not your problem. If you were able to log in via LTI 1.3 authentication, then it should obtain an access token at that time. If a job to pass grades back follows, then it should work. Although, in my recent work on this, I thought of something that might be your issue, or at least something to try. I will give details next week. |
drgrice1
force-pushed
the
bugfix/lti-1.3-job-queue-submit-grade
branch
4 times, most recently
from
9878ad8 to
696ac55
Compare
Alex-Jordan
approved these changes
Feb 14, 2024
drgrice1
force-pushed
the
bugfix/lti-1.3-job-queue-submit-grade
branch
2 times, most recently
from
17c97d1 to
714509f
Compare
drgrice1
force-pushed
the
bugfix/lti-1.3-job-queue-submit-grade
branch
3 times, most recently
from
02b9c12 to
1d40ae1
Compare
…d from the job queue.
The `get_access_token` method calls `$c->url_for` (on line 141 of
`WeBWorK::Authen::LTIAdvantage::SubmitGrade`. This is only called if
the access token is not saved in the database or if the access token
that is saved is expired. When this is called from the minion job
queue, `$c` is not a `Mojolicious::Controller`. Instead it is an
unblessed hash reference that has the keys `ce`, `db`, and `app`
defined. Clearly that unblessed hash reference will not have the
`url_for` method. As such, the job will fail if a new access token is
needed. So as is done on line 249 in the `submit_grade` method, the
`$c` object needs to be switched to the passed in `$c->{app}` object,
which does have the `url_for` method.
Note that with the current code this method will still succeed if the
database has an unexpired access token stored. Also, this method will
succeed if called with a `Mojolicious::Controller` object (for instance
when called in the case that a student initially logs in via LTI 1.3
authentication or in the case that a student submits an answer to a
problem or grades a test).
This could be considered for a hotfix.
drgrice1
force-pushed
the
bugfix/lti-1.3-job-queue-submit-grade
branch
from
1d40ae1 to
c10f3c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
get_access_tokenmethod calls$c->url_for(on line 141 ofWeBWorK::Authen::LTIAdvantage::SubmitGrade. This is only called if the access token is not saved in the database or if the access token that is saved is expired. When this is called from the minion job queue,$cis not aMojolicious::Controller. Instead it is an unblessed hash reference that has the keysce,db, andappdefined. Clearly that unblessed hash reference will not have theurl_formethod. As such, the job will fail if a new access token is needed. So as is done on line 249 in thesubmit_grademethod, the$cobject needs to be switched to the passed in$c->{app}object, which does have theurl_formethod.Note that with the current code this method will still succeed if the database has an unexpired access token stored. Also, this method will succeed if called with a
Mojolicious::Controllerobject (for instance when called in the case that a student initially logs in via LTI 1.3 authentication or in the case that a student submits an answer to a problem or grades a test).This could be considered for a hotfix.