-
-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move settings from site.conf into webwork2.mojolicious.yml #2314
Open
pstaabp
wants to merge
3
commits into
openwebwork:develop
Choose a base branch
from
pstaabp:remove-site-conf
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,8 +9,6 @@ are made to `.dist` files, then the modifications will be lost or cause conflict | |
|
||
Basic webwork2 configuration files. | ||
|
||
- `site.conf.dist` should be copied to `site.conf`, and contains global variables required for basic server | ||
configuration. This file is read first in the initialization sequence. | ||
- `defaults.config` contains initial settings for many customizable options in WeBWorK. This file is read second in the | ||
initialization sequence. **This file should not be changed** | ||
- `localOverrides.conf.dist` should be copied to `localOverrides.conf`. `localOverrides.conf` will be read after the | ||
|
@@ -29,8 +27,7 @@ Configuration extension files. | |
|
||
Server configuration files. | ||
|
||
- `webwork2.mojolicious.dist.yml` contains the webwork2 Mojolicious app configuration settings. Copy this file to | ||
`webwork2.mojolicious.yml` if you need to change those settings. You usually will need to do this. | ||
- `webwork2.mojolicious.dist.yml` contains the webwork2 Mojolicious app configuration settings. | ||
- `webwork2.dist.service` is a systemd configuration file for linux systems that serves the webwork2 app via the | ||
Mojolicious hypnotoad server. If you need to change it, then copy it to `webwork2.service`. | ||
- `webwork2-job-queue.dist.service` is a systemd configuration file for linux systems that runs the webwork2 job queue | ||
|
@@ -42,8 +39,9 @@ Server configuration files. | |
|
||
## Initial configururation of webwork2 | ||
|
||
- Copy `site.conf.dist` to `site.conf` and `localOverrides.conf.dist` to `localOverrides.conf`, and adjust the variables | ||
in `site.conf` as needed. In particular you will need to set `$server_root_url` to the server name, and set | ||
- Copy `webwork2.mojolicious.dist.yml` to `webwork2.mojolicious.yml` and change appropriate settings. | ||
- Copy `localOverrides.conf.dist` to `localOverrides.conf`, and adjust the variables | ||
as needed. In particular you will need to set `$server_root_url` to the server name, and set | ||
`$database_password` to the password for the database. | ||
- Adjust the variables in `localOverrides.conf` to customize your server for your needs. | ||
- Copy any of the other `.dist` files and adjust the variables in them as needed. Note that those files will need to be | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There are comments about |
||
|
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of these references to variables that were in
site.conf
need to be updated. They are no longer perl variables, and so the$
should be removed.