Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move settings from site.conf into webwork2.mojolicious.yml #2314

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ COPY docker-config/docker-entrypoint.sh /usr/local/bin/

ENTRYPOINT ["docker-entrypoint.sh"]

# Add enviroment variables to control some things during container startup
# Add environment variables to control some things during container startup
ENV SSL=0 \
PAPERSIZE=letter \
SYSTEM_TIMEZONE=UTC \
Expand Down
2 changes: 1 addition & 1 deletion DockerfileStage2
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ COPY docker-config/docker-entrypoint.sh /usr/local/bin/

ENTRYPOINT ["docker-entrypoint.sh"]

# Add enviroment variables to control some things during container startup
# Add environment variables to control some things during container startup
ENV SSL=0 \
PAPERSIZE=letter \
SYSTEM_TIMEZONE=UTC \
Expand Down
10 changes: 4 additions & 6 deletions conf/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@ are made to `.dist` files, then the modifications will be lost or cause conflict

Basic webwork2 configuration files.

- `site.conf.dist` should be copied to `site.conf`, and contains global variables required for basic server
configuration. This file is read first in the initialization sequence.
- `defaults.config` contains initial settings for many customizable options in WeBWorK. This file is read second in the
initialization sequence. **This file should not be changed**
- `localOverrides.conf.dist` should be copied to `localOverrides.conf`. `localOverrides.conf` will be read after the
Expand All @@ -29,8 +27,7 @@ Configuration extension files.

Server configuration files.

- `webwork2.mojolicious.dist.yml` contains the webwork2 Mojolicious app configuration settings. Copy this file to
`webwork2.mojolicious.yml` if you need to change those settings. You usually will need to do this.
- `webwork2.mojolicious.dist.yml` contains the webwork2 Mojolicious app configuration settings.
- `webwork2.dist.service` is a systemd configuration file for linux systems that serves the webwork2 app via the
Mojolicious hypnotoad server. If you need to change it, then copy it to `webwork2.service`.
- `webwork2-job-queue.dist.service` is a systemd configuration file for linux systems that runs the webwork2 job queue
Expand All @@ -42,8 +39,9 @@ Server configuration files.

## Initial configururation of webwork2

- Copy `site.conf.dist` to `site.conf` and `localOverrides.conf.dist` to `localOverrides.conf`, and adjust the variables
in `site.conf` as needed. In particular you will need to set `$server_root_url` to the server name, and set
- Copy `webwork2.mojolicious.dist.yml` to `webwork2.mojolicious.yml` and change appropriate settings.
- Copy `localOverrides.conf.dist` to `localOverrides.conf`, and adjust the variables
as needed. In particular you will need to set `$server_root_url` to the server name, and set
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these references to variables that were in site.conf need to be updated. They are no longer perl variables, and so the $ should be removed.

`$database_password` to the password for the database.
- Adjust the variables in `localOverrides.conf` to customize your server for your needs.
- Copy any of the other `.dist` files and adjust the variables in them as needed. Note that those files will need to be
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are comments about site.conf further down in this file that need to be updated.

Expand Down
340 changes: 0 additions & 340 deletions conf/database.conf.dist

This file was deleted.

Loading
Loading