Change the preview button name for the RPC endpoints. #2311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pstaabp
approved these changes
Feb 6, 2024
drgrice1
force-pushed
the
rpc-render-button-name
branch
2 times, most recently
from
b669c3c to
098fb27
Compare
This fixes issue openwebwork#2310 in the simple way I mention there. This also only makes the change mentioned for the preview button, and does not address the submit/check answers button issue. A discussion is needed on the best fix for this though.
drgrice1
force-pushed
the
rpc-render-button-name
branch
from
098fb27 to
60b7ec1
Compare
Alex-Jordan
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #2310 in the simple way I mention there. This also only makes the change mentioned for the preview button, and does not address the submit/check answers button issue.
A discussion is needed on the best fix for this though.