Remove PG translations and don't add those to the po and pot files. #2225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pstaabp
reviewed
Oct 6, 2023
|
|
||
| xgettext.pl -o webwork2.pot -D $WEBWORK_ROOT/lib -D $PG_ROOT/lib -D $PG_ROOT/macros -D $WEBWORK_ROOT/templates \ | ||
| xgettext.pl -o webwork2.pot -D $WEBWORK_ROOT/lib -D -D $WEBWORK_ROOT/templates \ |
There was a problem hiding this comment.
I think there's an extra -D on this line.
There was a problem hiding this comment.
Thanks for pointing that out. I did that in this and an the paired PG pull request. I fixed both. I am a little surprised the script was still working with that.
pstaabp
approved these changes
Oct 6, 2023
drgrice1
force-pushed
the
remove-pg-localization
branch
2 times, most recently
from
0537a3e to
99969cc
Compare
This was referenced Oct 7, 2023
drgrice1
force-pushed
the
remove-pg-localization
branch
3 times, most recently
from
e30bb5b to
1b8fe19
Compare
PG will no longer use the language handle from webwork2. It will now provide its own language handle. So the PG code is no longer scanned for translations. Also, the new WeBWorK::PG::Localize module is shared to PG's safe compartment. That is PG's language handle code.
drgrice1
force-pushed
the
remove-pg-localization
branch
from
1b8fe19 to
7b21258
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PG will no longer use the language handle from webwork2. It will now provide its own language handle. So the PG code is no longer scanned for translations.
Also, the new WeBWorK::PG::Localize module is shared to PG's safe compartment. That is PG's language handle module.
This is the alternate to #2213 that we discussed.
This is paired with openwebwork/pg#936.
Note that the po and pot files have not actually been updated. So at this point all of PG's translations are still in those files. Those are saved for now, but can be removed later.