Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the course_id from the past_answer table. #2196

Merged

Conversation

drgrice1
Copy link
Member

It is time for this to go. It is an entirely unnecessary column. This is taken care of by the usual course upgrade procedure in the admin course.

Don't test this on a course that you want to go back to other branches with! It isn't so easy to add the course_id column back. It can be done though if needed.

@drgrice1 drgrice1 force-pushed the remove-course_id-from-past-answer branch from 96af3d8 to 3d71efa Compare August 23, 2023 02:47
Copy link
Member

@pstaabp pstaabp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Both tested for a given course as well as an unarchived course (needed to upgrade first).

@drgrice1 drgrice1 force-pushed the remove-course_id-from-past-answer branch from 3d71efa to 490b795 Compare September 11, 2023 21:50
@drgrice1 drgrice1 force-pushed the remove-course_id-from-past-answer branch from 490b795 to ff45eb8 Compare September 19, 2023 18:37
@drgrice1 drgrice1 force-pushed the remove-course_id-from-past-answer branch 3 times, most recently from d969104 to 8d6fdbe Compare October 10, 2023 00:02
@drgrice1 drgrice1 force-pushed the remove-course_id-from-past-answer branch 2 times, most recently from 6f47390 to e35d780 Compare October 23, 2023 21:47
@drgrice1 drgrice1 force-pushed the remove-course_id-from-past-answer branch from e35d780 to 9d8f630 Compare October 30, 2023 21:36
@drgrice1 drgrice1 force-pushed the remove-course_id-from-past-answer branch 4 times, most recently from 20becba to 9cd6c2d Compare November 11, 2023 11:32
@drgrice1 drgrice1 force-pushed the remove-course_id-from-past-answer branch from 9cd6c2d to 6016084 Compare November 16, 2023 19:34
It is time for this to go. It is an entirely unnecessary column. This is
taken care of by the usual course upgrade procedure in the admin course.

Don't test this on a course that you want to go back to other branches
with! It isn't so easy to add the course_id column back. It can be
done though if needed.
@drgrice1 drgrice1 force-pushed the remove-course_id-from-past-answer branch from 6016084 to b1a95a2 Compare November 20, 2023 23:20
@drdrew42 drdrew42 merged commit 98252a5 into openwebwork:develop Nov 27, 2023
1 check passed
@drgrice1 drgrice1 deleted the remove-course_id-from-past-answer branch November 27, 2023 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants