Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nonzero scores for unattempted problems in the Grades page #2627

Open
Alex-Jordan opened this issue Nov 21, 2024 · 1 comment
Open

nonzero scores for unattempted problems in the Grades page #2627

Alex-Jordan opened this issue Nov 21, 2024 · 1 comment

Comments

@Alex-Jordan
Copy link
Contributor

In a set, suppose a user never attempted some problem, but has 100% for it. Maybe because that score was manually awarded. Maybe from some achievement item (although perhaps achievement items that change a score also set the problem's "attempted" flag?)

Then you get something like this in Grades:

Screenshot 2024-11-20 at 7 54 31 PM

This is a set where I manually awarded myself 100% on all exercises. Not using the problem grader, just using the old school Set Details page for my user and entering 1 for all the status values. Later I actually did Submit the first two exercises.

So you can see I have 15/15, but the display for my unattempted problems is confusing.

Is this how this should be?

@somiaj
Copy link
Contributor

somiaj commented Nov 21, 2024

Seems the grade table wasn't designed with achievements or grade overrides in mind. Probably best to just show the 100% status even when a problem hasn't been attempted. Here is the line in the grade_set method that is doing it.

push(@$problem_scores,             $problemRecord->attempted ? 100 * wwRound(2, $status) : ' . ');

I agree that this might be confusing to students who have used an achievement. Maybe this should be changed to:

push(@$problem_scores, $status || $problemRecord->attempted ? 100 * wwRound(2, $status) : ' . ');

I already have a PR to correctly show green highlighting with reduced scoring enabled to help improve this page, I could add this to that (though I do know you are also working on the grade_set method with your PR).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants