Skip to content

Commit

Permalink
remove unused argument to grade_gateway()
Browse files Browse the repository at this point in the history
  • Loading branch information
Alex-Jordan committed Nov 8, 2024
1 parent c27f281 commit bfda906
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion lib/Caliper/Entity.pm
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,7 @@ sub problem_set_attempt {
my $extensions = { 'attempt_score' => $score, };

if ($version_id) {
$extensions->{'gateway_score'} = grade_gateway($db, $problem_set_user, $problem_set_user->set_id, $user_id);
$extensions->{'gateway_score'} = grade_gateway($db, $problem_set_user->set_id, $user_id);
}

my $problem_set_attempt = {
Expand Down
2 changes: 1 addition & 1 deletion lib/WeBWorK/Authen/LTIAdvanced/SubmitGrade.pm
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ async sub submit_set_grade ($self, $userID, $setID) {
my $date;

if ($userSet->assignment_type =~ /gateway/) {
$score = scalar(grade_gateway($db, $userSet, $userSet->set_id, $userID));
$score = scalar(grade_gateway($db, $userSet->set_id, $userID));
$attempted = gateway_attempted($db, $userSet, $userSet->set_id, $userID);
$date = earliest_gateway_date($db, $userSet->set_id, $userID, $ce->{LTISendScoresAfterDate});
} else {
Expand Down
2 changes: 1 addition & 1 deletion lib/WeBWorK/Authen/LTIAdvantage/SubmitGrade.pm
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ async sub submit_set_grade ($self, $userID, $setID) {
my $date;

if ($userSet->assignment_type =~ /gateway/) {
($totalRight, $total) = grade_gateway($db, $userSet, $userSet->set_id, $userID);
($totalRight, $total) = grade_gateway($db, $userSet->set_id, $userID);
$attempted = gateway_attempted($db, $userSet, $userSet->set_id, $userID);
$date = earliest_gateway_date($db, $userSet->set_id, $userID, $ce->{LTISendScoresAfterDate});
} else {
Expand Down
6 changes: 3 additions & 3 deletions lib/WeBWorK/Utils/Sets.pm
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ sub grade_set ($db, $set, $studentName, $setIsVersioned = 0, $wantProblemDetails
}
}

sub grade_gateway ($db, $set, $setName, $studentName) {
sub grade_gateway ($db, $setName, $studentName) {
my @versionNums = $db->listSetVersions($studentName, $setName);

my $bestTotalRight = 0;
Expand Down Expand Up @@ -204,7 +204,7 @@ sub grade_all_sets ($db, $studentName, $sendScoresAfterDate = 'open_date', $send
my $date;

if ($userSet->assignment_type() =~ /gateway/) {
($totalRight, $total) = grade_gateway($db, $userSet, $userSet->set_id, $studentName);
($totalRight, $total) = grade_gateway($db, $userSet->set_id, $studentName);
$attempted = gateway_attempted($db, $userSet->set_id, $studentName);
$date = earliest_gateway_date($db, $userSet->set_id, $studentName, $sendScoresAfterDate);
} else {
Expand Down Expand Up @@ -378,7 +378,7 @@ In scalar context this returns the percentage correct.
=head2 grade_gateway
Usage: C<grade_gateway($db, $set, $setName, $studentName)>
Usage: C<grade_gateway($db, $setName, $studentName)>
All arguments are required.
Expand Down

0 comments on commit bfda906

Please sign in to comment.