Increase the tolerance when checking OTP codes.

This makes two factor authentication work more reliably for DUO.
openwebwork · Mar 16, 2024 · a878478 · a878478
1 parent 5d9ea65
commit a878478
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/lib/WeBWorK/Authen.pm b/lib/WeBWorK/Authen.pm
@@ -483,8 +483,12 @@ sub verify_normal_user {
 			my $otp_code = trim($c->param('otp_code'));
 			if (defined $otp_code && $otp_code ne '') {
 				my $password = $c->db->getPassword($user_id);
-				if (WeBWorK::Utils::TOTP->new(secret => $self->session->{otp_secret} // $password->otp_secret)
-					->validate_otp($otp_code))
+				if (
+					WeBWorK::Utils::TOTP->new(
+						secret    => $self->session->{otp_secret} // $password->otp_secret,
+						tolerance => 1
+					)->validate_otp($otp_code)
+					)
 				{
 					delete $self->session->{two_factor_verification_needed};