Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #42

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TomCJones
Copy link

added use case

added use case
@OR13
Copy link
Contributor

OR13 commented Nov 30, 2022

@tkuhrt anything I need to do for the DCO ?

@tkuhrt
Copy link
Collaborator

tkuhrt commented Nov 30, 2022

Looks like someone enabled DCO checks on the repo. All commits will need to be done with git commit -s. This page from Hyperledger Indy provides some info on signing commits and previous commits.

@OR13
Copy link
Contributor

OR13 commented Dec 6, 2022

Is there an option to NOT require this repo be doing what it is now?

I don't feel like this is an improvement.

Do I have permission to merge over the current error?

I don't feel like the contributor should be required to review anything related to Hyperledger Indy to contribute here.

@tkuhrt
Copy link
Collaborator

tkuhrt commented Dec 6, 2022

@OR13 : DCO is required by the charter. I assume someone at the Linux Foundation enabled this check, as I did not. There are many places that explain how to fix DCO, the one I linked to in Indy is just one of them. Here is the top result from Google for "fix DCO sign off for PR"

@OR13
Copy link
Contributor

OR13 commented Dec 6, 2022

@tkuhrt I am taking your response as a blocker for merging and I am requesting changes.

@OR13 OR13 self-requested a review December 6, 2022 18:39
Copy link
Contributor

@OR13 OR13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please address the DCO issue noted above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants