Make vc libraries mandatory #3356
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swcurran
previously approved these changes
Nov 26, 2024
jamshale
force-pushed
the
vc-libraries
branch
2 times, most recently
from
7f060cb
to
c73e1ed
Compare
|
@jamshale I would suggest to add |
Signed-off-by: jamshale <[email protected]>
Signed-off-by: jamshale <[email protected]>
Signed-off-by: jamshale <[email protected]>
Signed-off-by: jamshale <[email protected]>
Signed-off-by: jamshale <[email protected]>
jamshale
force-pushed
the
vc-libraries
branch
from
c73e1ed
to
cdabab6
Compare
Signed-off-by: jamshale <[email protected]>
jamshale
force-pushed
the
vc-libraries
branch
from
fdb66e8
to
5a769a6
Compare
|
dbluhm
approved these changes
Dec 3, 2024
swcurran
approved these changes
Dec 3, 2024
PatStLouis
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently both vc libraries are required to be installed and they should not be extras.
This is mainly due to compatibility reason. When indy is fully retired indy-credx should be able to be an extra or completely removed and contained within a plugin.