Add test wallet config option #3355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbluhm
reviewed
Nov 26, 2024
jamshale
force-pushed
the
add-test-wallet-config
branch
from
da380ee
to
47fd807
Compare
Signed-off-by: jamshale <[email protected]>
Signed-off-by: jamshale <[email protected]>
Signed-off-by: jamshale <[email protected]>
jamshale
force-pushed
the
add-test-wallet-config
branch
from
47fd807
to
33775dd
Compare
|
PatStLouis
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the removal of the in-memory wallet we lost the ability to quickly spin up an in-memory agent without a wallet name or key. This adds the ability back if you use the new
--wallet-testconfig. It will create an in-memory askar wallet.If you don't use
wallet-testand fail to supply name and key you now get a wallet-name and wallet-key required for persistent wallet error on startup.