VC DI proof request #2960

sarthakvijayvergiya · 2024-05-21T18:09:05Z

Presentation request (DIF) for VC_DI credentials

sonarcloud · 2024-05-21T18:09:20Z

Quality Gate passed

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

ianco · 2024-06-04T17:42:52Z

I know this is still WIP, but we need to have a description on the PR (is necessary in case anyone needs to look back on this PR in the future, and is also used for release notes). Also it's good - if the PR is in WIP state - to make a note of what is done and what's still outstanding ...

aries_cloudagent/protocols/present_proof/v2_0/routes.py

ianco · 2024-06-16T16:45:32Z

Also just noticed the commit is missing the DCO signoff

Signed-off-by: Sarthak Vijayvergiya <[email protected]>

Signed-off-by: EmadAnwer <[email protected]>

Signed-off-by: Sarthak Vijayvergiya <[email protected]>

…est_web_request object for revocation Signed-off-by: EmadAnwer <[email protected]>

Signed-off-by: EmadAnwer <[email protected]>

- getting the correct timestamp - create rev_states - remove static code Signed-off-by: EmadAnwer <[email protected]>

Signed-off-by: EmadAnwer <[email protected]>

Signed-off-by: Emad <[email protected]>

to - create_rev_states - prepare_data_for_presentation Signed-off-by: EmadAnwer <[email protected]>

add - prepare_data_for_presentation - _load_w3c_credentials functions remove holder flag Signed-off-by: EmadAnwer <[email protected]>

Additional integration tests for vc_di and revocation

- test_assert_no_callenge_error - test_assert_verify_presentation - test__extract_cred_idx - test__get_predicate_type_and_value - test__load_w3c_credentials Signed-off-by: EmadAnwer <[email protected]>

ianco

A couple of comments to be removed (minor issue) and unit test coverage (SonarCloud reports 27 new lines in each of aries_cloudagent/anoncreds/holder.py and aries_cloudagent/vc/vc_di/prove.py that are not covered - I think 2 simple "happy path" tests could cover most of this).

Also PR description ... (@EmadAnwer not sure if you mentioned you can't edit the description?)

Overall looks really good!

demo/runners/agent_container.py

ianco · 2024-07-11T16:27:31Z

aries_cloudagent/protocols/present_proof/v2_0/formats/dif/handler.py

@@ -169,7 +171,7 @@ async def create_pres(
            domain = proof_request["options"].get("domain")
        if not challenge:
            challenge = str(uuid4())
-
+        # TODO handle vc_di format in the future


This comment can be removed

- test_create_presentation_w3c - test_create_presentation_w3c_create_error Signed-off-by: EmadAnwer <[email protected]>

- test_create_signed_anoncreds_presentation Signed-off-by: EmadAnwer <[email protected]>

Signed-off-by: Emad <[email protected]>

Signed-off-by: EmadAnwer <[email protected]>

- test_store_credential_w3c - test_get_type_manager_options Signed-off-by: EmadAnwer <[email protected]>

jamshale · 2024-07-11T23:00:57Z

There is quite a few things reported in sonarcloud. I don't think everything needs to be addressed but some definitely should like the unused variable and shadow variable names.

https://sonarcloud.io/project/issues?id=hyperledger_aries-cloudagent-python&pullRequest=2960&resolved=false&sinceLeakPeriod=true

Maybe have a go over and see if we can make some improvements. I think overall the code looks good and well tested.

ianco · 2024-07-11T23:05:30Z

There is quite a few things reported in sonarcloud. I don't think everything needs to be addressed but some definitely should like the unused variable and shadow variable names.

https://sonarcloud.io/project/issues?id=hyperledger_aries-cloudagent-python&pullRequest=2960&resolved=false&sinceLeakPeriod=true

Maybe have a go over and see if we can make some improvements. I think overall the code looks good and well tested.

Good catch @jamshale

@EmadAnwer can you review the SonarCloud report and do a bit of cleanup? As Jamie says we don't need to address everything but take a pass and see what you think.

ianco

SonarCloud as noted by Jamie

EmadAnwer · 2024-07-12T05:40:10Z

There is quite a few things reported in sonarcloud. I don't think everything needs to be addressed but some definitely should like the unused variable and shadow variable names.
https://sonarcloud.io/project/issues?id=hyperledger_aries-cloudagent-python&pullRequest=2960&resolved=false&sinceLeakPeriod=true
Maybe have a go over and see if we can make some improvements. I think overall the code looks good and well tested.

Good catch @jamshale

@EmadAnwer can you review the SonarCloud report and do a bit of cleanup? As Jamie says we don't need to address everything but take a pass and see what you think.

yes sure

Signed-off-by: EmadAnwer <[email protected]>

sonarcloud · 2024-07-12T06:33:51Z

Quality Gate passed

Issues
12 New issues
0 Accepted issues

Measures
0 Security Hotspots
86.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

EmadAnwer · 2024-07-12T07:00:06Z

Quality Gate passed

Issues 12 New issues 0 Accepted issues

Measures 0 Security Hotspots 86.4% Coverage on New Code 0.0% Duplication on New Code

See analysis details on SonarCloud

There is quite a few things reported in sonarcloud. I don't think everything needs to be addressed but some definitely should like the unused variable and shadow variable names.
https://sonarcloud.io/project/issues?id=hyperledger_aries-cloudagent-python&pullRequest=2960&resolved=false&sinceLeakPeriod=true
Maybe have a go over and see if we can make some improvements. I think overall the code looks good and well tested.

Good catch @jamshale
@EmadAnwer can you review the SonarCloud report and do a bit of cleanup? As Jamie says we don't need to address everything but take a pass and see what you think.

yes sure

@jamshale @ianco I have fixed most of it, check it please, let me know if there are any suggestions

jamshale · 2024-07-12T15:05:20Z

I'm going to merge this. Would be nice to have in the 1.0.0 release and don't predict any regressions.

swcurran · 2024-07-12T15:21:49Z

w00t!!! Awesome.

* WIP: vc di proof request - authored by ianco(openwallet-foundation#3043) Signed-off-by: Sarthak Vijayvergiya <[email protected]> * fixed lint checks, cleanup Signed-off-by: Sarthak Vijayvergiya <[email protected]> * fix: verify_pres, get_sign_key_credential_subject_id Signed-off-by: EmadAnwer <[email protected]> * WIP: debugging revocation & fixes Signed-off-by: Sarthak Vijayvergiya <[email protected]> * WIP: fix ununsed import Signed-off-by: Sarthak Vijayvergiya <[email protected]> * refactor: create_signed_anoncreds_presentation, faber vcdi proof_request_web_request object for revocation Signed-off-by: EmadAnwer <[email protected]> * Refactor:Add W3cCredential loading for VCDI format handler Signed-off-by: EmadAnwer <[email protected]> * fix: tests Signed-off-by: EmadAnwer <[email protected]> * WPA: using static data to test the revocation validation Signed-off-by: EmadAnwer <[email protected]> * feat: Add revocation support to VCDI - getting the correct timestamp - create rev_states - remove static code Signed-off-by: EmadAnwer <[email protected]> * Remove unused code for credential definition and revocation Signed-off-by: EmadAnwer <[email protected]> * WPA: fix lint Signed-off-by: EmadAnwer <[email protected]> * Fix cred search for vc_di proof Signed-off-by: EmadAnwer <[email protected]> * Additional integration tests for vc_di and revocation Signed-off-by: Ian Costanzo <[email protected]> * refactor: remove unused comments and TODO's - implement _extract_cred_idx - add try catch to some expected fail code Signed-off-by: EmadAnwer <[email protected]> * refactor: split create_signed_anoncreds_presentation to - create_rev_states - prepare_data_for_presentation Signed-off-by: EmadAnwer <[email protected]> * refactor: `create_signed_anoncreds_presentation` add - prepare_data_for_presentation - _load_w3c_credentials functions remove holder flag Signed-off-by: EmadAnwer <[email protected]> * add: tests - test_assert_no_callenge_error - test_assert_verify_presentation - test__extract_cred_idx - test__get_predicate_type_and_value - test__load_w3c_credentials Signed-off-by: EmadAnwer <[email protected]> * add: tests, remove todos - test_create_presentation_w3c - test_create_presentation_w3c_create_error Signed-off-by: EmadAnwer <[email protected]> * add: tests - test_create_signed_anoncreds_presentation Signed-off-by: EmadAnwer <[email protected]> * fix: linter Signed-off-by: EmadAnwer <[email protected]> * fix: remove unused imports Signed-off-by: EmadAnwer <[email protected]> * add: tests - test_store_credential_w3c - test_get_type_manager_options Signed-off-by: EmadAnwer <[email protected]> * refactor: remove extra variables and comments Signed-off-by: EmadAnwer <[email protected]> --------- Signed-off-by: Sarthak Vijayvergiya <[email protected]> Signed-off-by: EmadAnwer <[email protected]> Signed-off-by: Emad <[email protected]> Signed-off-by: Ian Costanzo <[email protected]> Co-authored-by: EmadAnwer <[email protected]> Co-authored-by: Ian Costanzo <[email protected]>

sarthakvijayvergiya marked this pull request as draft June 5, 2024 06:58

sarthakvijayvergiya changed the title ~~feat: VC DI proof request~~ [WIP] feat: VC DI proof request Jun 5, 2024

sarthakvijayvergiya force-pushed the whatscookin/feat/vc-di-proof branch 2 times, most recently from 4dee13e to e344a1d Compare June 5, 2024 10:22

sarthakvijayvergiya commented Jun 5, 2024

View reviewed changes

aries_cloudagent/protocols/present_proof/v2_0/routes.py Outdated Show resolved Hide resolved

sarthakvijayvergiya closed this Jun 18, 2024

sarthakvijayvergiya force-pushed the whatscookin/feat/vc-di-proof branch from 8208477 to 75f6c53 Compare June 18, 2024 16:57

sarthakvijayvergiya reopened this Jun 18, 2024

sarthakvijayvergiya force-pushed the whatscookin/feat/vc-di-proof branch 5 times, most recently from e3a364d to 4fee8fa Compare June 20, 2024 13:36

sarthakvijayvergiya added 2 commits June 28, 2024 20:31

WIP: vc di proof request - authored by ianco(openwallet-foundation#3043)

23ad5bd

Signed-off-by: Sarthak Vijayvergiya <[email protected]>

fixed lint checks, cleanup

742a7df

Signed-off-by: Sarthak Vijayvergiya <[email protected]>

sarthakvijayvergiya force-pushed the whatscookin/feat/vc-di-proof branch from 4fee8fa to 742a7df Compare June 28, 2024 18:31

EmadAnwer and others added 7 commits June 28, 2024 22:20

fix: verify_pres, get_sign_key_credential_subject_id

92db3ea

Signed-off-by: EmadAnwer <[email protected]>

WIP: debugging revocation & fixes

dd800b0

Signed-off-by: Sarthak Vijayvergiya <[email protected]>

WIP: fix ununsed import

c7077dd

Signed-off-by: Sarthak Vijayvergiya <[email protected]>

refactor: create_signed_anoncreds_presentation, faber vcdi proof_requ…

147fbb9

…est_web_request object for revocation Signed-off-by: EmadAnwer <[email protected]>

Refactor:Add W3cCredential loading for VCDI format handler

72f2d08

Signed-off-by: EmadAnwer <[email protected]>

fix: tests

6ad8125

Signed-off-by: EmadAnwer <[email protected]>

WPA: using static data to test the revocation validation

c13a3df

Signed-off-by: EmadAnwer <[email protected]>

EmadAnwer force-pushed the whatscookin/feat/vc-di-proof branch from 6f53dc0 to c13a3df Compare July 4, 2024 19:56

EmadAnwer added 3 commits July 6, 2024 21:12

feat: Add revocation support to VCDI

2626b19

- getting the correct timestamp - create rev_states - remove static code Signed-off-by: EmadAnwer <[email protected]>

Remove unused code for credential definition and revocation

1034c80

Signed-off-by: EmadAnwer <[email protected]>

Merge branch 'main' into whatscookin/feat/vc-di-proof

d02441e

Signed-off-by: Emad <[email protected]>

EmadAnwer and others added 5 commits July 8, 2024 23:18

refactor: split create_signed_anoncreds_presentation

e58f1aa

to - create_rev_states - prepare_data_for_presentation Signed-off-by: EmadAnwer <[email protected]>

refactor: create_signed_anoncreds_presentation

a037382

add - prepare_data_for_presentation - _load_w3c_credentials functions remove holder flag Signed-off-by: EmadAnwer <[email protected]>

Merge pull request #3 from ianco/w3c-proof-req-2

dc351a4

Additional integration tests for vc_di and revocation

Merge branch 'main' into whatscookin/feat/vc-di-proof

852fa6a

add: tests

c10c928

- test_assert_no_callenge_error - test_assert_verify_presentation - test__extract_cred_idx - test__get_predicate_type_and_value - test__load_w3c_credentials Signed-off-by: EmadAnwer <[email protected]>

ianco requested changes Jul 11, 2024

View reviewed changes

EmadAnwer added 5 commits July 11, 2024 21:01

add: tests, remove todos

494ab81

- test_create_presentation_w3c - test_create_presentation_w3c_create_error Signed-off-by: EmadAnwer <[email protected]>

add: tests

b623dae

- test_create_signed_anoncreds_presentation Signed-off-by: EmadAnwer <[email protected]>

Merge branch 'main' into whatscookin/feat/vc-di-proof

6365822

Signed-off-by: Emad <[email protected]>

fix: linter

b30d88d

Signed-off-by: EmadAnwer <[email protected]>

fix: remove unused imports

d13136c

Signed-off-by: EmadAnwer <[email protected]>

EmadAnwer force-pushed the whatscookin/feat/vc-di-proof branch from ac32d5e to d13136c Compare July 11, 2024 19:37

add: tests

0170055

- test_store_credential_w3c - test_get_type_manager_options Signed-off-by: EmadAnwer <[email protected]>

ianco approved these changes Jul 11, 2024

View reviewed changes

ianco requested a review from jamshale July 11, 2024 22:27

jamshale changed the title ~~[WIP] feat: VC DI proof request~~ VC DI proof request Jul 11, 2024

ianco requested changes Jul 11, 2024

View reviewed changes

refactor: remove extra variables and comments

116a992

Signed-off-by: EmadAnwer <[email protected]>

ianco approved these changes Jul 12, 2024

View reviewed changes

jamshale approved these changes Jul 12, 2024

View reviewed changes

jamshale merged commit a1a5afc into openwallet-foundation:main Jul 12, 2024
8 checks passed

jamshale mentioned this pull request Jul 15, 2024

Add DIF presentation exchange context and cache document #3093

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

VC DI proof request #2960

VC DI proof request #2960

sarthakvijayvergiya commented May 21, 2024 •

edited by ianco

Loading

sonarcloud bot commented May 21, 2024

ianco commented Jun 4, 2024

ianco commented Jun 16, 2024

ianco left a comment

ianco Jul 11, 2024

jamshale commented Jul 11, 2024 •

edited

Loading

ianco commented Jul 11, 2024

ianco left a comment

EmadAnwer commented Jul 12, 2024

sonarcloud bot commented Jul 12, 2024

EmadAnwer commented Jul 12, 2024

Quality Gate passed

jamshale commented Jul 12, 2024

swcurran commented Jul 12, 2024

VC DI proof request #2960

VC DI proof request #2960

Conversation

sarthakvijayvergiya commented May 21, 2024 • edited by ianco Loading

sonarcloud bot commented May 21, 2024

Quality Gate passed

ianco commented Jun 4, 2024

ianco commented Jun 16, 2024

ianco left a comment

Choose a reason for hiding this comment

ianco Jul 11, 2024

Choose a reason for hiding this comment

jamshale commented Jul 11, 2024 • edited Loading

ianco commented Jul 11, 2024

ianco left a comment

Choose a reason for hiding this comment

EmadAnwer commented Jul 12, 2024

sonarcloud bot commented Jul 12, 2024

Quality Gate passed

EmadAnwer commented Jul 12, 2024

Quality Gate passed

jamshale commented Jul 12, 2024

swcurran commented Jul 12, 2024

sarthakvijayvergiya commented May 21, 2024 •

edited by ianco

Loading

jamshale commented Jul 11, 2024 •

edited

Loading