-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Verifiable Credential Data Integrity (VC-DI) Credentials in Aries Cloud Agent Python (ACA-Py) #2947
DOC: Verifiable Credential Data Integrity (VC-DI) Credentials in Aries Cloud Agent Python (ACA-Py) #2947
Conversation
Signed-off-by: supersonicwisd1 <[email protected]>
@jamshale given that this is just a doc update, I'm guessing the integration test failure is a fluke? Any insights? |
Yes. This is the one I've seen twice now. Somehow the integration test creates a race condition when setting the endorser's role. Very random. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this is pretty high level, but I'll defer to @swcurran as to how much documentation is required.
I think there is more info required tho on the implementation, and a reference in the demo docs for how to select this credential type in the demo.
} | ||
``` | ||
|
||
### Issue a Credential |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this section needs a bit more description, an example of ow to issue the credential and a high-level description of how the process works.
(Likewise for the present proof, which I assume will come after the implementation is complete.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted. I should include that soon
Quality Gate passedIssues Measures |
Signed-off-by: supersonicwisd1 <[email protected]>
Yes, I should add the select between indy and vc_di soon. Thank for the review. |
Quality Gate passedIssues Measures |
Signed-off-by: supersonicwisd1 <[email protected]>
Signed-off-by: supersonicwisd1 <[email protected]>
DOC: Verifiable Credential Data Integrity (VC-DI) Credentials in Aries Cloud Agent Python (ACA-Py) #2947
No description provided.