Reactivate ASAN for crypt format #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that the recent patches applied have fixed the issue we were experiencing. To be sure, I need to find an old run that failed and run it again using the latest upstream bleeding code. Signed-off-by: Claudio André <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
It appears that the recent fixes applied upstream have fixed the issue we were experiencing. We are comparing 100% failure in the past with 3 successful runs today [1].
To be sure, I need to find an old run (an old version of the Docker image) that failed and run it again using the latest upstream bleeding code.
[1] This is already a strong indication that something has been improved/fixed.
Issue ticket number and link
Fix openwall/john#5411
See openwall/john#5491 (rare event; perhaps related?)