Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-user support + Init script #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

artemkv
Copy link

@artemkv artemkv commented Oct 15, 2019

I recently tried to use this helm chart and ran into some limitations. I made some improvements I needed in the fork. If you like them, please feel free to accept the pull request. If not, feel free to simply pick the pieces you liked.

Improvements:

  • Included pull request fixing a missing indent in sftp-container resource definition (Fixed missing indent in sftp-container resource definition. #6)
  • Support for multiple users having different passwords and mounting different paths on a persistent volume. This allows to configure 2 users, one for external, more limited access, and one for internal, less limited access
  • Support for init script
  • I also changed the default image to atmoz/sftp

…nting different paths on a persistent volume

- Added support for init script
| `sftpConfig.encrypted` | If true, password is given as hash | `false` |
| `sftpConfig.uid` | UID of SFTP user | `1000` |
| `sftpConfig.gid` | GID of SFTP user | `100` |
| `sftpConfig.users.username` | SFTP username | `sftp` |

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README should be updated to show that the fields under users are items in a list of users, not fields directly attached to users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants