Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language classifier API #66

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

sbrugman
Copy link

@sbrugman sbrugman commented Sep 8, 2020

This PR aims to finish the feature proposed in #56

  • Squashes the commits to keep a cleaner git history
  • Adds a usage example to the Readme
  • Fixes a type annotation

@sbrugman sbrugman force-pushed the language_classifier branch from ccb54db to 8bd1079 Compare September 8, 2020 18:24
@sbrugman
Copy link
Author

sbrugman commented Sep 8, 2020

@albarrentine The tests are passing, bringing the language classifier to Python users :) Please consider merging. (#56 may be closed)

@SercanKaraoglu
Copy link

hi, this very useful thanks for the pr, please approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants