Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename hover to interest #814

Merged
merged 2 commits into from
Aug 24, 2023
Merged

Rename hover to interest #814

merged 2 commits into from
Aug 24, 2023

Conversation

mfreed7
Copy link
Collaborator

@mfreed7 mfreed7 commented Aug 24, 2023

Per the resolution:

This also updates the articles and references section to include that, and adds a bit more text explaining the new name.

Per the resolution:

- [OpenUI: Resolution to use `interest` as the name of the value](openui#767 (comment))

This also updates the articles and references section to include that, and adds a bit more text explaining the new name.
Copy link
Collaborator

@dbaron dbaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, with one optional comment.

@mfreed7 mfreed7 merged commit 4f7b2ec into openui:main Aug 24, 2023
Copy link
Collaborator

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@mfreed7
Copy link
Collaborator Author

mfreed7 commented Aug 24, 2023

Thanks to you both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants