Update explainer with recent resolutions #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregwhitworth
approved these changes
May 30, 2022
| - When a popup is hidden, focus is set back to the **previously focused element**, if it is non-`null`, in the following cases: | ||
| 1. Light dismiss via close signal (e.g. Escape key pressed). | ||
| 2. Hide popup from Javascript via `hidePopup()`. | ||
| 3. Hide popup via a **popup-contained** triggering element with `hidepopup=popup_id` or `togglepopup=popup=id`. The triggering element must be popup-contained, otherwise the keyboard or mouse activation of the triggering element should have already moved focus to that element. |
There was a problem hiding this comment.
Again not blocking this PR but we should have some examples of these solutions.
There was a problem hiding this comment.
I added another sentence, but I'm open to specific suggestions for examples here.
|
@scottaohara @dandclark can you all give this a quick review. @mfreed7 if this isn't reviewed by the upcoming Thursday go ahead and land it as they can always file new issues if they find it. |
scottaohara
reviewed
Jun 1, 2022
hidde
reviewed
Jun 1, 2022
dandclark
approved these changes
Jun 1, 2022
|
Thanks for all of the reviews! I've addressed all of the comments, I think. LMK if you see anything else. |
|
Any other comments? Mind if we land this? |
andrico1234
approved these changes
Jun 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the explainer for a number of recent resolutions, including these:
popup=popuptopopup=auto:top-layerpseudo classpopupattributeshowandhideevents should not be cancelabledelegatesfocus